From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Date: Tue, 9 Jan 2018 15:41:35 +0200 Message-ID: <20180109134135.32i6slkhmqsjnmne@tarshish> References: <2013811470.181895.1514918984637@email.1und1.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2013811470.181895.1514918984637-7tX72C7vayboQLBSYMtkGA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Dave Stevenson , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , Eric Anholt List-Id: devicetree@vger.kernel.org Hi Stefan, On Tue, Jan 02, 2018 at 07:49:44PM +0100, Stefan Wahren wrote: [...] > > + ret = rpi_firmware_property(gpio->fw, RPI_FIRMWARE_GET_GPIO_CONFIG, > > + &get, sizeof(get)); > > + if (ret) { > > + dev_err(gpio->dev, > > + "Failed to get GPIO %u config (%d)\n", off, ret); > > + return ret; > > + } > > Shouldn't we also check the in-bound status at get.gpio? What is the in-bound status value? May you refer me to the documentation? > And in all the other gpio ops? Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.52.368.4656, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html