* [PATCH v4 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora [not found] <20180112012755.20495-1-chris.packham@alliedtelesis.co.nz> @ 2018-01-12 1:27 ` Chris Packham [not found] ` <20180112012755.20495-6-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Chris Packham @ 2018-01-12 1:27 UTC (permalink / raw) To: linux, bp, jlu Cc: thomas.petazzoni, Mark Rutland, devicetree, linux-kernel, Rob Herring, Chris Packham, kernel, gregory.clement, linux-arm-kernel The aurora cache on the Marvell Armada-XP SoC supports ECC protection for the L2 data arrays. Add a "marvell,ecc-enable" device tree property which can be used to enable this. Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> [jlu@pengutronix.de: use aurora specific define AURORA_ACR_ECC_EN] Signed-off-by: Jan Luebbe <jlu@pengutronix.de> --- Documentation/devicetree/bindings/arm/l2c2x0.txt | 2 ++ arch/arm/mm/cache-l2x0.c | 7 +++++++ 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/l2c2x0.txt b/Documentation/devicetree/bindings/arm/l2c2x0.txt index fbe6cb21f4cf..15a84f0ba9f1 100644 --- a/Documentation/devicetree/bindings/arm/l2c2x0.txt +++ b/Documentation/devicetree/bindings/arm/l2c2x0.txt @@ -76,6 +76,8 @@ Optional properties: specified to indicate that such transforms are precluded. - arm,parity-enable : enable parity checking on the L2 cache (L220 or PL310). - arm,parity-disable : disable parity checking on the L2 cache (L220 or PL310). +- marvell,ecc-enable : enable ECC protection on the L2 cache +- marvell,ecc-disable : disable ECC protection on the L2 cache - arm,outer-sync-disable : disable the outer sync operation on the L2 cache. Some core tiles, especially ARM PB11MPCore have a faulty L220 cache that will randomly hang unless outer sync operations are disabled. diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c index b70bee74750d..644f786e4fa9 100644 --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c @@ -1505,6 +1505,13 @@ static void __init aurora_of_parse(const struct device_node *np, mask |= AURORA_ACR_FORCE_WRITE_POLICY_MASK; } + if (of_property_read_bool(np, "marvell,ecc-enable")) { + mask |= AURORA_ACR_ECC_EN; + val |= AURORA_ACR_ECC_EN; + } else if (of_property_read_bool(np, "marvell,ecc-disable")) { + mask |= AURORA_ACR_ECC_EN; + } + if (of_property_read_bool(np, "arm,parity-enable")) { mask |= AURORA_ACR_PARITY_EN; val |= AURORA_ACR_PARITY_EN; -- 2.15.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
[parent not found: <20180112012755.20495-6-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>]
* Re: [PATCH v4 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora [not found] ` <20180112012755.20495-6-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> @ 2018-01-19 21:28 ` Rob Herring 0 siblings, 0 replies; 2+ messages in thread From: Rob Herring @ 2018-01-19 21:28 UTC (permalink / raw) To: Chris Packham Cc: linux-I+IVW8TIWO2tmTQ+vhA3Yw, bp-Gina5bIWoIWzQB+pC5nmwQ, jlu-bIcnvbaLZ9MEGnE8C9+IrQ, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8, kernel-bIcnvbaLZ9MEGnE8C9+IrQ, gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Fri, Jan 12, 2018 at 02:27:52PM +1300, Chris Packham wrote: > The aurora cache on the Marvell Armada-XP SoC supports ECC protection > for the L2 data arrays. Add a "marvell,ecc-enable" device tree property > which can be used to enable this. > > Signed-off-by: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> > [jlu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org: use aurora specific define AURORA_ACR_ECC_EN] > Signed-off-by: Jan Luebbe <jlu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > --- > Documentation/devicetree/bindings/arm/l2c2x0.txt | 2 ++ > arch/arm/mm/cache-l2x0.c | 7 +++++++ > 2 files changed, 9 insertions(+) The Calxeda PL310 has ECC too so maybe shouldn't have a vendor prefix, but I don't think anyone will ever care to change it at this point. Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180112012755.20495-1-chris.packham@alliedtelesis.co.nz>
2018-01-12 1:27 ` [PATCH v4 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora Chris Packham
[not found] ` <20180112012755.20495-6-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2018-01-19 21:28 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).