From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH v5 2/2] media: V3s: Add support for Allwinner CSI. Date: Fri, 12 Jan 2018 09:37:49 +0100 Message-ID: <20180112083749.syxtwiigxafxw4zq@flea.lan> References: <1515639966-35902-1-git-send-email-yong.deng@magewell.com> <20180111132844.mok7upqjycpx3bqm@flea.lan> <20180112095114.b2414fe44cff7bf7cf6f8822@magewell.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mzjxflidhun7f3lz" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20180112095114.b2414fe44cff7bf7cf6f8822-+3dxTMOEIRNWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Yong Cc: Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Chen-Yu Tsai , "David S. Miller" , Greg Kroah-Hartman , Randy Dunlap , Hans Verkuil , Stanimir Varbanov , Hugues Fruchet , Yannick Fertre , Philipp Zabel , Arnd Bergmann , Benjamin Gaignard , Ramesh Shanmugasundaram , Sakari Ailus , Rick Chang , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, megous@mego List-Id: devicetree@vger.kernel.org --mzjxflidhun7f3lz Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Fri, Jan 12, 2018 at 09:51:14AM +0800, Yong wrote: > Hi Maxime, > > On Thu, 11 Jan 2018 14:28:44 +0100 > Maxime Ripard wrote: > > > Hi Yong, > > > > On Thu, Jan 11, 2018 at 11:06:06AM +0800, Yong Deng wrote: > > > Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > > > interface and CSI1 is used for parallel interface. This is not > > > documented in datasheet but by test and guess. > > > > > > This patch implement a v4l2 framework driver for it. > > > > > > Currently, the driver only support the parallel interface. MIPI-CSI2, > > > ISP's support are not included in this patch. > > > > > > Signed-off-by: Yong Deng > > > > I've needed this patch in order to fix a NULL pointer dereference: > > http://code.bulix.org/oz6gmb-257359?raw > > > > This is needed because while it's ok to have a NULL pointer to > > v4l2_subdev_pad_config when you call the subdev set_fmt with > > V4L2_SUBDEV_FORMAT_ACTIVE, it's not with V4L2_SUBDEV_FORMAT_TRY, and > > sensors will assume taht it's a valid pointer. > > > > Otherwise, > > Tested-by: Maxime Ripard > > I revisit some code of subdevs and you are right. > > Squash your patch into my driver patch and add your Tested-by in > commit. Is it right? Yep, that's perfect :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --mzjxflidhun7f3lz--