From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sebastian Reichel
<sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
Vivien Didelot
<vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>,
Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
Ian Ray <ian.ray-JJi787mZWgc@public.gmane.org>,
Nandor Han <nandor.han-JJi787mZWgc@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv4 1/5] net: dsa: Support internal phy on 'cpu' port
Date: Mon, 22 Jan 2018 21:54:59 +0100 [thread overview]
Message-ID: <20180122205459.GF2467@lunn.ch> (raw)
In-Reply-To: <09a9c406-85c1-0f84-4032-db243f825ca2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Note: there is still technically a misreprentation of how the PHY is
> "attached" to the network device. In your DTSes, you have to have the
> CPU port have a "phy-handle" to the internal PHY, while technically it
> should be the i210 which has a "phy-handle" property to that PHY, and
> even better, if the e1000e/idb drivers were PHYLIB capable, they could
> manage it directly.
Hi Florian
Err, i don't think i agree. But maybe i'm missunderstanding.
We have two back-to-back PHYs. I would expect the i210 MAC to have a
phy-handle pointing it its PHY. The CPU port would then point to the
internal switch PHY.
Or are you suggesting the i210 has two phy-handles, its own and the
switches?
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-22 20:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 10:19 [PATCHv4 0/5] GEHC Bx50 Switch Support Sebastian Reichel
2018-01-16 10:19 ` [PATCHv4 1/5] net: dsa: Support internal phy on 'cpu' port Sebastian Reichel
2018-01-17 21:04 ` David Miller
2018-01-22 20:16 ` David Miller
2018-01-22 20:25 ` Florian Fainelli
[not found] ` <09a9c406-85c1-0f84-4032-db243f825ca2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-22 20:54 ` Andrew Lunn [this message]
[not found] ` <20180122205459.GF2467-g2DYL2Zd6BY@public.gmane.org>
2018-01-22 20:56 ` Florian Fainelli
2018-01-22 21:57 ` Sebastian Reichel
2018-01-16 10:19 ` [PATCHv4 2/5] ARM: dts: imx6q-bx50v3: Add internal switch Sebastian Reichel
2018-01-16 10:19 ` [PATCHv4 3/5] ARM: dts: imx6q-b850v3: Add switch port configuration Sebastian Reichel
2018-01-16 10:19 ` [PATCHv4 4/5] ARM: dts: imx6q-b650v3: " Sebastian Reichel
2018-01-16 10:19 ` [PATCHv4 5/5] ARM: dts: imx6q-b450v3: " Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122205459.GF2467@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \
--cc=ian.ray-JJi787mZWgc@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nandor.han-JJi787mZWgc@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).