From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 2/2] mfd: syscon: Add hardware spinlock support Date: Tue, 23 Jan 2018 09:11:28 +0000 Message-ID: <20180123091128.uqiot64vup566syo@dell> References: <29fa88f883dae4c1f8a3acb2656cbd7c5a539d40.1514180039.git.baolin.wang@linaro.org> <20180111152219.yzit67dzdshi3cxs@dell> <20180122134336.e7phrckbpwvxwsfz@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Baolin Wang Cc: Arnd Bergmann , Rob Herring , Mark Rutland , Mark Brown , LKML , DTML List-Id: devicetree@vger.kernel.org On Tue, 23 Jan 2018, Baolin Wang wrote: > Hi Lee, > > On 22 January 2018 at 21:43, Lee Jones wrote: > > On Thu, 11 Jan 2018, Lee Jones wrote: > >> On Mon, 25 Dec 2017, Baolin Wang wrote: > >> > >> > Some system control registers need hardware spinlock to synchronize > >> > between the multiple subsystems, so we should add hardware spinlock > >> > support for syscon. > >> > > >> > Signed-off-by: Baolin Wang > >> > Acked-by: Rob Herring > >> > --- > >> > Changes since v6: > >> > - Treat hwlock id 0 as valid for regmap. > >> > > >> > Changes since v5: > >> > - Fix the case that hwspinlock is not enabled. > >> > > >> > Changes since v4: > >> > - Add one exapmle to show how to add hwlock. > >> > - Fix the coding style issue. > >> > > >> > Changes since v3: > >> > - Add error handling for of_hwspin_lock_get_id() > >> > > >> > Changes since v2: > >> > - Add acked tag from Rob. > >> > > >> > Changes since v1: > >> > - Remove timeout configuration. > >> > - Modify the binding file to add hwlocks. > >> > --- > >> > Documentation/devicetree/bindings/mfd/syscon.txt | 8 ++++++++ > >> > drivers/mfd/syscon.c | 19 +++++++++++++++++++ > >> > 2 files changed, 27 insertions(+) > >> > >> Applied, thanks. > > > > In order to avoid confusion, I should like to tell you that this patch > > is applied for v4.17, not v4.16. > > This patch has been applied into Mark's branch[1] with your ACK, so > Mark should drop this patch from his branch and you will pick it and > merge it into v4.17? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=topic/hwspinlock&id=3bafc09e779710abaa7b836fe3bbeeeab7754c2b Ah, this is the one that failed to build when merged alone. Very well. Ignore my last. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog