From: Shawn Guo <shawn.guo@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
linux-pci@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
project-aspen-dev@linaro.org,
Jianguo Sun <sunjianguo1@huawei.com>
Subject: Re: [PATCH] PCI: histb: add power control GPIO for PCIe slot
Date: Tue, 23 Jan 2018 18:54:25 +0800 [thread overview]
Message-ID: <20180123105424.GB23797@dragon> (raw)
In-Reply-To: <CAOMZO5DFR=qJ_Q9ag+6Ov92VMZL3wiLSQJee=nKUJFtZ1mW1RQ@mail.gmail.com>
On Mon, Jan 22, 2018 at 11:12:44PM -0200, Fabio Estevam wrote:
> Hi Shawn,
>
> On Mon, Jan 22, 2018 at 11:04 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > From: Jianguo Sun <sunjianguo1@huawei.com>
> >
> > Besides the GPIO for controlling reset, there is also possibly another
> > GPIO for turning on/off the power of PCIe slot. Let's add the support
> > for that with another optional device tree property 'power-gpios'.
>
> It seems that a better approach would be to add regulator support
> instead as it is more general.
It's a sensible suggestion. I will take it in v2. Thanks, Fabio.
Shawn
next prev parent reply other threads:[~2018-01-23 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 1:04 [PATCH] PCI: histb: add power control GPIO for PCIe slot Shawn Guo
2018-01-23 1:12 ` Fabio Estevam
2018-01-23 10:54 ` Shawn Guo [this message]
[not found] ` <1516669477-20151-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-23 9:39 ` [project-aspen-dev] " Daniel Thompson
[not found] ` <20180123093944.rxysbjm2u6suycco-Xg7FH8f/bVM@public.gmane.org>
2018-01-23 10:52 ` Shawn Guo
2018-03-02 12:10 ` Lorenzo Pieralisi
2018-03-02 12:36 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123105424.GB23797@dragon \
--to=shawn.guo@linaro.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=project-aspen-dev@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sunjianguo1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).