From: Pavel Machek <pavel@ucw.cz>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, perex@perex.cz, tiwai@suse.com,
bhumirks@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
pali.rohar@gmail.com, sre@kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
clayton@craftyguy.net, martijn@brixit.nl,
sakari.ailus@linux.intel.com,
"Filip Matijević" <filip.matijevic.pz@gmail.com>
Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support
Date: Tue, 30 Jan 2018 00:33:01 +0100 [thread overview]
Message-ID: <20180129233301.GA18104@amd> (raw)
In-Reply-To: <20180129232031.GA7695@lenoch>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On Tue 2018-01-30 00:20:31, Ladislav Michl wrote:
> On Tue, Jan 30, 2018 at 12:05:39AM +0100, Pavel Machek wrote:
> >
> > This adds device tree support to tlv320dac33.c.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >
> > diff --git a/Documentation/devicetree/bindings/sound/tlv320dac33.txt b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
> > new file mode 100644
> > index 0000000..6cbd311
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/tlv320dac33.txt
> > @@ -0,0 +1,32 @@
> > +Texas Instruments - tlv320dac33 Codec module
> > +
> > +The tlv320dac33 serial control bus communicates through I2C protocols.
> > +
> > +Required properties:
> > +
> > +- compatible - "ti,tlv320dac33"
> > +- reg - I2C slave address
> > +
> > +Optional properties:
> > +
> > +- power-gpios - gpio pin to power the device, active high
>
> While driver used gpio in platform data, isn't it more likely
> regulator which powers device?
power-gpios = <&gpio2 28 0>; /* gpio_60 */
Looks like GPIO to me -- example is from Nokia N9. So this appears to
be correct.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-01-29 23:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 23:05 [PATCH] sound/tlv320dac33: Add device tree support Pavel Machek
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:33 ` Pavel Machek [this message]
2018-01-30 8:34 ` Ladislav Michl
2018-01-30 8:53 ` Pavel Machek
2018-01-30 9:11 ` Filip Matijević
[not found] ` <1141b126-b883-a246-85ad-c5a69acb90bb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:10 ` Ladislav Michl
2018-01-30 10:35 ` Pavel Machek
2018-01-30 11:38 ` Ladislav Michl
2018-01-31 9:24 ` Peter Ujfalusi
2018-01-30 11:32 ` Mark Brown
[not found] ` <20180130113238.GA10525-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-01-30 12:28 ` Pavel Machek
2018-01-31 9:12 ` Peter Ujfalusi
2018-01-31 19:01 ` [PATCHv2] tlv320dac33: Add device tree bindings Pavel Machek
2018-02-01 7:39 ` Peter Ujfalusi
2018-02-05 8:24 ` [PATCHv3] " Pavel Machek
2018-02-06 12:11 ` Mark Brown
[not found] ` <20180206121122.GG5681-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-06 13:49 ` Pavel Machek
2018-02-06 15:27 ` Mark Brown
2018-02-24 20:57 ` Pavel Machek
2018-03-05 12:52 ` Peter Ujfalusi
2018-02-09 2:25 ` Rob Herring
2018-02-05 6:08 ` [PATCHv2] " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129233301.GA18104@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhumirks@gmail.com \
--cc=broonie@kernel.org \
--cc=clayton@craftyguy.net \
--cc=devicetree@vger.kernel.org \
--cc=filip.matijevic.pz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=ladis@linux-mips.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martijn@brixit.nl \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).