From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
wakasugi.jb@om.asahi-kasei.co.jp,
Cosmin Samoila <cosmin.samoila@nxp.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Mihai Serban <mihai.serban@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mihai Serban <mihai.serban@gmail.com>
Subject: Re: [PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver
Date: Sat, 3 Feb 2018 00:11:02 +0100 [thread overview]
Message-ID: <20180202231102.GA2705@sirena.org.uk> (raw)
In-Reply-To: <CAHp75VfyVfGdCfjV_iaXFcRcanbgwFSgJRfu8eojdbMONMUOaQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 891 bytes --]
On Fri, Feb 02, 2018 at 09:33:18PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 2, 2018 at 6:20 PM, Daniel Baluta <daniel.baluta@nxp.com> wrote:
> > +static int ak5558_set_dai_mute(struct snd_soc_dai *dai, int mute)
> > +{
> > + struct snd_soc_codec *codec = dai->codec;
> > + struct ak5558_priv *ak5558 = snd_soc_codec_get_drvdata(codec);
>
> > + int ndt = 0;
>
> It might be even
>
> int ndt = max(ak5558->fs ? 583000 / ak5558->fs : 5, 5);
Please don't encourage people to use the ternery operator like that, it
does nothing for legibility not to write out the conditionals.
> > +static const struct i2c_device_id ak5558_i2c_id[] = {
> > + { "ak5558", 0 },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, ak5558_i2c_id);
> I dunno if it's really helpful to have. Though it's up to Mark and you.
I don't care either way.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-02-02 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 16:20 [PATCH v2 0/2] Add support for AK5558 ADC Daniel Baluta
2018-02-02 16:20 ` [PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver Daniel Baluta
2018-02-02 19:33 ` Andy Shevchenko
2018-02-02 23:11 ` Mark Brown [this message]
[not found] ` <20180202231102.GA2705-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-04 14:31 ` Andy Shevchenko
2018-02-04 14:42 ` Daniel Baluta
2018-02-02 16:20 ` [PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC Daniel Baluta
2018-02-02 22:48 ` [alsa-devel] " Fabio Estevam
[not found] ` <1517588406-3295-3-git-send-email-daniel.baluta-3arQi8VN3Tc@public.gmane.org>
2018-02-05 6:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202231102.GA2705@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.serban@gmail.com \
--cc=mihai.serban@nxp.com \
--cc=shengjiu.wang@nxp.com \
--cc=wakasugi.jb@om.asahi-kasei.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).