From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 07/10] ARM: sun8i: h3: add SY8113B regulator used by Orange Pi One board
Date: Tue, 6 Feb 2018 10:10:57 +0100 [thread overview]
Message-ID: <20180206091057.6uy4fdcfztgmjjlz@flea> (raw)
In-Reply-To: <20180206044905.30508-8-icenowy@aosc.io>
[-- Attachment #1.1: Type: text/plain, Size: 1281 bytes --]
On Tue, Feb 06, 2018 at 12:49:02PM +0800, Icenowy Zheng wrote:
> Orange Pi One board has a SY8113B regulator, which is controlled via
> GPIO and capable of outputing 1.1V when the PL6 GPIO is set to output 0
> or 1.3V when the PL6 GPIO is set to input or output 1, and the output is
> the power supply of the ARM cores in H3 SoC.
>
> Add the device tree node of this regulator and set the cpu's cpu-supply
> property to it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> New patch in v2.
>
> arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> index 82e5d28cd698..d8250aacfda1 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
> @@ -88,6 +88,27 @@
> gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
> };
> };
> +
> + reg_sy8113b: gpio-regulator {
There's multiple of them on those boards, so the name and label should
avoid conflicting names (this also applies to your other patches).
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-02-06 9:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 4:48 [PATCH v2 00/10] Allwinner H3 DVFS support Icenowy Zheng
2018-02-06 4:48 ` [PATCH v2 01/10] dt-bindings: add binding for the SY8106A voltage regulator Icenowy Zheng
[not found] ` <20180206044905.30508-1-icenowy-h8G6r0blFSE@public.gmane.org>
2018-02-06 4:48 ` [PATCH v2 02/10] regulator: add support for SY8106A regulator Icenowy Zheng
[not found] ` <20180206044905.30508-3-icenowy-h8G6r0blFSE@public.gmane.org>
2018-03-30 8:03 ` Chen-Yu Tsai
2018-02-06 4:48 ` [PATCH v2 03/10] ARM: sunxi: h3/h5: Add r_i2c pinmux node Icenowy Zheng
2018-02-06 4:48 ` [PATCH v2 04/10] ARM: sunxi: h3/h5: Add r_i2c I2C controller Icenowy Zheng
2018-02-06 4:49 ` [PATCH v2 05/10] ARM: sun8i: h3: add operating-points-v2 table for CPU Icenowy Zheng
[not found] ` <20180206044905.30508-6-icenowy-h8G6r0blFSE@public.gmane.org>
2018-02-06 9:06 ` Maxime Ripard
2018-02-06 9:10 ` Icenowy Zheng
2018-02-06 4:49 ` [PATCH v2 06/10] ARM: sun8i: h2+: add SY8113B regulator used by Orange Pi Zero board Icenowy Zheng
[not found] ` <20180206044905.30508-7-icenowy-h8G6r0blFSE@public.gmane.org>
2018-03-30 7:49 ` Chen-Yu Tsai
2018-02-06 4:49 ` [PATCH v2 07/10] ARM: sun8i: h3: add SY8113B regulator used by Orange Pi One board Icenowy Zheng
2018-02-06 9:10 ` Maxime Ripard [this message]
2018-02-06 4:49 ` [PATCH v2 08/10] ARM: sun8i: h3: Add SY8106A regulator to Orange Pi PC Icenowy Zheng
[not found] ` <20180206044905.30508-9-icenowy-h8G6r0blFSE@public.gmane.org>
2018-03-30 8:16 ` Chen-Yu Tsai
2018-02-06 4:49 ` [PATCH v2 10/10] ARM: sun8i: h3: set the cpu-supply to VDD-CPUX on ALL-H3-CC H3 ver Icenowy Zheng
2018-04-16 4:41 ` [PATCH v2 00/10] Allwinner H3 DVFS support Chen-Yu Tsai
[not found] ` <CAGb2v67FaU3_su9XGaGj4zVSoAnpfN8cAhbBHEJu3Owt=Qicmg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-04-16 4:47 ` Chen-Yu Tsai
2018-04-24 2:10 ` [linux-sunxi] " Chen-Yu Tsai
2018-02-06 4:49 ` [PATCH v2 09/10] ARM: sun8i: h3: fix ALL-H3-CC H3 ver VDD-CPUX voltage Icenowy Zheng
[not found] ` <20180206044905.30508-10-icenowy-h8G6r0blFSE@public.gmane.org>
2018-03-30 7:43 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206091057.6uy4fdcfztgmjjlz@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox