devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
Cc: "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Gerlach, Dave" <d-gerlach-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: am437x-idk: Configure uart0 padconf wakeirq
Date: Mon, 12 Feb 2018 07:31:22 -0800	[thread overview]
Message-ID: <20180212153122.GA6364@atomide.com> (raw)
In-Reply-To: <b5fba201-a1ad-9192-27a6-f7d8d5bc6a40-l0cyMroinI0@public.gmane.org>

* Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org> [180212 04:53]:
> Hi,
> 
> On Friday 09 February 2018 09:49 PM, Tony Lindgren wrote:
> > We can use CTRL_CONF_UART0_RXD pad as the wakeirq and then
> > the serial console will work with wake up events.
> > 
> > Note that the uart still needs to be configured for idle
> > timeouts for PM runtime for the wakeirq to get activated.
> > That can be done via sysfs to set autosuspend_delay_ms to
> > 3000, wakeup enabled and and control auto.
> > 
> > Cc: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>
> > Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/am437x-idk-evm.dts | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/am437x-idk-evm.dts
> > b/arch/arm/boot/dts/am437x-idk-evm.dts
> > --- a/arch/arm/boot/dts/am437x-idk-evm.dts
> > +++ b/arch/arm/boot/dts/am437x-idk-evm.dts
> > @@ -533,3 +533,9 @@
> >                  opp-suspend;
> >          };
> >  };
> > +
> > +&uart0 {
> > +       /* UART0 interrupt and CTRL_CONF_UART0_RXD pad as wakeirq */
> > +       interrupts-extended = <&gic GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> > +                             <&am43xx_pinmux 0x170>;
> > +};
> 
> As per Section 6.4.5 Wakeup Sources/Events AM437x TRM, UART0 is in
> Wakeup Power domain  and can wakeup the system directly. AFAIK, there is
> no need to use CTRL_CONF_UART0_RXD pad as the wakeirq.

OK, let's wait a bit on this until we can test suspend resume
with Dave's patches. I think this is still needed for runtime PM
as the UART is not able to wake up if it's configured for
autosuspend_delay_ms, or to wake up the system from suspend if the
UART is suspended.. But maybe you're right and the 8250 internal
wake-up can be used in this case :)

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2018-02-12 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 16:19 [PATCH] ARM: dts: am437x-idk: Configure uart0 padconf wakeirq Tony Lindgren
     [not found] ` <20180209161913.19542-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2018-02-12  4:53   ` Vignesh R
     [not found]     ` <b5fba201-a1ad-9192-27a6-f7d8d5bc6a40-l0cyMroinI0@public.gmane.org>
2018-02-12 15:31       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212153122.GA6364@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=d-gerlach-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vigneshr-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).