[PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property

[PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property

[Harald Geyer]

These two drivers fail to probe if no name is provided. For details see:
https://www.spinics.net/lists/kernel/msg2457515.html

Signed-off-by: Harald Geyer <harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
This is already the second resend for this trivial device probing bug
fix. It was written to your specification, got an ACK from devicetree
and has no unaddressed review comments, so I can't see what might be
holding it back. If there is still anything wrong with it, I'd appreciate
actual feedback instead of a canned response or silence.

BTW, it took me a bit to figure out that by "content free ping" you are
refering to the quoting of the patch. Maybe you can reword your canned
response to make it easier to understand.

The ACK was added in the (first) resend.

 Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 +
 Documentation/devicetree/bindings/regulator/gpio-regulator.txt  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
index 4fae41d..0c2a6c8 100644
--- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
@@ -2,6 +2,7 @@ Fixed Voltage regulators
 
 Required properties:
 - compatible: Must be "regulator-fixed";
+- regulator-name: Defined in regulator.txt as optional, but required here.
 
 Optional properties:
 - gpio: gpio to use for enable control
diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
index dd1ed78..1f49615 100644
--- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
@@ -2,6 +2,8 @@ GPIO controlled regulators
 
 Required properties:
 - compatible		: Must be "regulator-gpio".
+- regulator-name	: Defined in regulator.txt as optional, but required
+			  here.
 - states		: Selection of available voltages and GPIO configs.
                           if there are no states, then use a fixed regulator
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

On Tue, Feb 13, 2018 at 02:43:08PM +0000, Harald Geyer wrote:

> BTW, it took me a bit to figure out that by "content free ping" you are
> refering to the quoting of the patch. Maybe you can reword your canned
> response to make it easier to understand.

No, a content free ping is when you just send a reply saying something
to the effect of "hey, what's going on with this?".  As I said in my
reply best case the answer is going to be "I have no idea, you need to
resend since I'll need the patch to do anything with it" and worst case
it just won't get seen at all if the thing really did get buried
somehow.  This is unfortunately something that happens upstream, things
fall through the cracks sometimes for various reasons (eg, if a new
patch gets sent in the middle of a thread sometimes it'll get deleted
along with the reset of the thread).  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property

[Harald Geyer]

Mark Brown writes:
> On Tue, Feb 13, 2018 at 02:43:08PM +0000, Harald Geyer wrote:
> 
> > BTW, it took me a bit to figure out that by "content free ping" you are
> > refering to the quoting of the patch. Maybe you can reword your canned
> > response to make it easier to understand.
> 
> No, a content free ping is when you just send a reply saying something
> to the effect of "hey, what's going on with this?".

Well, I did quote the entire patch and gave a summary of the status
as far as I know it. So I really don't understand why I got the
"no content free pings" response ...

> As I said in my
> reply best case the answer is going to be "I have no idea, you need to
> resend since I'll need the patch to do anything with it" and worst case
> it just won't get seen at all if the thing really did get buried
> somehow.

So you are saying you don't want pings as followups to patches at all, if
the patch is old enough that it probably got lost?

I guess that would make sense too, but again it's not obvious to read
the canned response that way.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH,RESEND2] regulator: fixed, gpio: dt: regulator-name is required property

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

On Wed, Feb 14, 2018 at 11:00:12AM +0100, Harald Geyer wrote:
> Mark Brown writes:

> > No, a content free ping is when you just send a reply saying something
> > to the effect of "hey, what's going on with this?".

> Well, I did quote the entire patch and gave a summary of the status
> as far as I know it. So I really don't understand why I got the
> "no content free pings" response ...

Which just boils down to a "what's going on with this" message.

> > As I said in my
> > reply best case the answer is going to be "I have no idea, you need to
> > resend since I'll need the patch to do anything with it" and worst case
> > it just won't get seen at all if the thing really did get buried
> > somehow.

> So you are saying you don't want pings as followups to patches at all, if
> the patch is old enough that it probably got lost?

> I guess that would make sense too, but again it's not obvious to read
> the canned response that way.

No, I'm saying don't send pings at all.  Resend patches if you think
they've got lost, and as normal when you're sending a patch it should
start off a new thread.  The goal is to send something that can be
directly acted on when it's seen rather than requring another round of
mails.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Applied "regulator: dt: regulator-name is required property" to the regulator tree

[Mark Brown]

The patch

   regulator: dt: regulator-name is required property

has been applied to the regulator tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 4b75291621830acad2c66a1d21d7840a7ca169d3 Mon Sep 17 00:00:00 2001
From: Harald Geyer <harald@ccbib.org>
Date: Tue, 13 Feb 2018 14:43:08 +0000
Subject: [PATCH] regulator: dt: regulator-name is required property

These two drivers fail to probe if no name is provided. For details see:
https://www.spinics.net/lists/kernel/msg2457515.html

Signed-off-by: Harald Geyer <harald@ccbib.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 +
 Documentation/devicetree/bindings/regulator/gpio-regulator.txt  | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
index 4fae41d54798..0c2a6c8a1536 100644
--- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
@@ -2,6 +2,7 @@ Fixed Voltage regulators
 
 Required properties:
 - compatible: Must be "regulator-fixed";
+- regulator-name: Defined in regulator.txt as optional, but required here.
 
 Optional properties:
 - gpio: gpio to use for enable control
diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
index dd1ed789728e..1f496159e2bb 100644
--- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
@@ -2,6 +2,8 @@ GPIO controlled regulators
 
 Required properties:
 - compatible		: Must be "regulator-gpio".
+- regulator-name	: Defined in regulator.txt as optional, but required
+			  here.
 - states		: Selection of available voltages and GPIO configs.
                           if there are no states, then use a fixed regulator
 
-- 
2.16.1

Re: Applied "regulator: dt: regulator-name is required property" to the regulator tree

[Geert Uytterhoeven]

On Wed, Feb 14, 2018 at 5:28 PM, Mark Brown <broonie@kernel.org> wrote:
> The patch
>
>    regulator: dt: regulator-name is required property
>
> has been applied to the regulator tree at
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
> From 4b75291621830acad2c66a1d21d7840a7ca169d3 Mon Sep 17 00:00:00 2001
> From: Harald Geyer <harald@ccbib.org>
> Date: Tue, 13 Feb 2018 14:43:08 +0000
> Subject: [PATCH] regulator: dt: regulator-name is required property
>
> These two drivers fail to probe if no name is provided. For details see:
> https://www.spinics.net/lists/kernel/msg2457515.html
>
> Signed-off-by: Harald Geyer <harald@ccbib.org>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>

What about using the DT node name instead, as is done for single-output
clocks?

> ---
>  Documentation/devicetree/bindings/regulator/fixed-regulator.txt | 1 +
>  Documentation/devicetree/bindings/regulator/gpio-regulator.txt  | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> index 4fae41d54798..0c2a6c8a1536 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> @@ -2,6 +2,7 @@ Fixed Voltage regulators
>
>  Required properties:
>  - compatible: Must be "regulator-fixed";
> +- regulator-name: Defined in regulator.txt as optional, but required here.
>
>  Optional properties:
>  - gpio: gpio to use for enable control
> diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> index dd1ed789728e..1f496159e2bb 100644
> --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt
> @@ -2,6 +2,8 @@ GPIO controlled regulators
>
>  Required properties:
>  - compatible           : Must be "regulator-gpio".
> +- regulator-name       : Defined in regulator.txt as optional, but required
> +                         here.
>  - states               : Selection of available voltages and GPIO configs.
>                            if there are no states, then use a fixed regulator

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: Applied "regulator: dt: regulator-name is required property" to the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

On Thu, Feb 15, 2018 at 10:39:41AM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 14, 2018 at 5:28 PM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:

> > Signed-off-by: Harald Geyer <harald-95f8Dae0BrPYtjvyW6yDsg@public.gmane.org>
> > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> What about using the DT node name instead, as is done for single-output
> clocks?

Yup, that'd work too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]