From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacopo mondi Subject: Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support Date: Wed, 14 Feb 2018 14:53:06 +0100 Message-ID: <20180214135306.GA23932@w540> References: <1518515162-23663-1-git-send-email-jacopo+renesas@jmondi.org> <1518515162-23663-5-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Jacopo Mondi , Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linux-Renesas , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org Hi Geert, thanks for review On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi > wrote: > > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > > No groups or functions defined, just pin and registers enumeration. > > > > Signed-off-by: Jacopo Mondi > > Thanks for your patch! > > Looks mostly OK to me. > You do want to compare with pfc-r8a7796.c: all differences not related to > SATA_DEVSL, FSCLK, DU_DOTCLKIN2/3, and PRESET are issues that were fixed > recently in pfc-r8a7796.c, and should apply to pfc-r8a77965.c, too. > I have used the M3-W tables with the exception of the pins/groups you mentioned, that are clearly marked as different in the datasheet. At least, this was my intention :) I used v4.15 M3-W PFC tables, should I look in v4.16-rc1 or in renesas-drivers for updates? > That leaves us with very few differences only, but it won't be trivial to have > a combined M3-W/N PFC driver, I'm afraid. > Takes a certain degree of grep-foo to clearly highlight differences between the two version. Do you have any script/tools you use to compare PFC tables a bit more easily? Thanks j > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html