* [PATCH] ARM: dts: porter: Add missing PMIC nodes
@ 2018-02-17 2:07 Marek Vasut
2018-02-18 15:07 ` Geert Uytterhoeven
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-02-17 2:07 UTC (permalink / raw)
To: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Marek Vasut,
Geert Uytterhoeven, Kuninori Morimoto, Simon Horman, Wolfram Sang
Add PMIC nodes to Porter and connect CPU DVFS supply. There is
one DA9063 and one DA9210 on Porter, the only difference from
the other boards is that DA9063 is at I2C address 0x5a rather
than 0x58 .
Signed-off-by: Marek Vasut <marek.vasut+renesas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Cc: Wolfram Sang <wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
---
arch/arm/boot/dts/r8a7791-porter.dts | 37 ++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts
index a098d66292fb..116f30f54e04 100644
--- a/arch/arm/boot/dts/r8a7791-porter.dts
+++ b/arch/arm/boot/dts/r8a7791-porter.dts
@@ -354,10 +354,47 @@
clock-frequency = <400000>;
};
+&i2c6 {
+ status = "okay";
+ clock-frequency = <100000>;
+
+ pmic@5a {
+ compatible = "dlg,da9063";
+ reg = <0x5a>;
+ interrupt-parent = <&irqc0>;
+ interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+
+ rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
+ };
+
+ vdd_dvfs: regulator@68 {
+ compatible = "dlg,da9210";
+ reg = <0x68>;
+ interrupt-parent = <&irqc0>;
+ interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+};
+
&sata0 {
status = "okay";
};
+&cpu0 {
+ cpu0-supply = <&vdd_dvfs>;
+};
+
/* composite video input */
&vin0 {
status = "okay";
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes
2018-02-17 2:07 [PATCH] ARM: dts: porter: Add missing PMIC nodes Marek Vasut
@ 2018-02-18 15:07 ` Geert Uytterhoeven
2018-02-23 16:45 ` Simon Horman
2018-02-24 22:11 ` Marek Vasut
0 siblings, 2 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2018-02-18 15:07 UTC (permalink / raw)
To: Marek Vasut
Cc: Linux-Renesas, linux-arm-kernel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Marek Vasut, Geert Uytterhoeven, Kuninori Morimoto, Simon Horman,
Wolfram Sang, Steve Twiss
Hi Marek,
CC Steve Twiss
On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> one DA9063 and one DA9210 on Porter, the only difference from
> the other boards is that DA9063 is at I2C address 0x5a rather
> than 0x58 .
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a7791-porter.dts
> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> @@ -354,10 +354,47 @@
> clock-frequency = <400000>;
> };
>
> +&i2c6 {
> + status = "okay";
> + clock-frequency = <100000>;
> +
> + pmic@5a {
> + compatible = "dlg,da9063";
Does it matter that this is a DA9063L ("Variant 6B")?
Do we need a new compatible value, or can this be detected at runtime?
> + reg = <0x5a>;
> + interrupt-parent = <&irqc0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> +
> + rtc {
> + compatible = "dlg,da9063-rtc";
> + };
> +
> + wdt {
> + compatible = "dlg,da9063-watchdog";
> + };
> + };
> +
> + vdd_dvfs: regulator@68 {
> + compatible = "dlg,da9210";
> + reg = <0x68>;
> + interrupt-parent = <&irqc0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +};
> +
> &sata0 {
> status = "okay";
> };
>
> +&cpu0 {
> + cpu0-supply = <&vdd_dvfs>;
> +};
> +
> /* composite video input */
> &vin0 {
> status = "okay";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes
2018-02-18 15:07 ` Geert Uytterhoeven
@ 2018-02-23 16:45 ` Simon Horman
2018-02-24 10:05 ` Marek Vasut
2018-02-24 22:11 ` Marek Vasut
1 sibling, 1 reply; 7+ messages in thread
From: Simon Horman @ 2018-02-23 16:45 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Kuninori Morimoto, Geert Uytterhoeven, Wolfram Sang,
Linux-Renesas, Marek Vasut, Steve Twiss, linux-arm-kernel,
Marek Vasut
On Sun, Feb 18, 2018 at 04:07:51PM +0100, Geert Uytterhoeven wrote:
> Hi Marek,
>
> CC Steve Twiss
>
> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> > one DA9063 and one DA9210 on Porter, the only difference from
> > the other boards is that DA9063 is at I2C address 0x5a rather
> > than 0x58 .
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r8a7791-porter.dts
> > +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> > @@ -354,10 +354,47 @@
> > clock-frequency = <400000>;
> > };
> >
> > +&i2c6 {
> > + status = "okay";
> > + clock-frequency = <100000>;
> > +
> > + pmic@5a {
> > + compatible = "dlg,da9063";
>
> Does it matter that this is a DA9063L ("Variant 6B")?
> Do we need a new compatible value, or can this be detected at runtime?
Hi Marek,
could you follow up on this?
> > + reg = <0x5a>;
> > + interrupt-parent = <&irqc0>;
> > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-controller;
> > +
> > + rtc {
> > + compatible = "dlg,da9063-rtc";
> > + };
> > +
> > + wdt {
> > + compatible = "dlg,da9063-watchdog";
> > + };
> > + };
> > +
> > + vdd_dvfs: regulator@68 {
> > + compatible = "dlg,da9210";
> > + reg = <0x68>;
> > + interrupt-parent = <&irqc0>;
> > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> > +
> > + regulator-min-microvolt = <1000000>;
> > + regulator-max-microvolt = <1000000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +};
> > +
> > &sata0 {
> > status = "okay";
> > };
> >
> > +&cpu0 {
> > + cpu0-supply = <&vdd_dvfs>;
> > +};
> > +
> > /* composite video input */
> > &vin0 {
> > status = "okay";
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes
2018-02-23 16:45 ` Simon Horman
@ 2018-02-24 10:05 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2018-02-24 10:05 UTC (permalink / raw)
To: Simon Horman, Geert Uytterhoeven
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Kuninori Morimoto, Linux-Renesas,
Wolfram Sang, Steve Twiss, linux-arm-kernel, Marek Vasut
On 02/23/2018 05:45 PM, Simon Horman wrote:
> On Sun, Feb 18, 2018 at 04:07:51PM +0100, Geert Uytterhoeven wrote:
>> Hi Marek,
>>
>> CC Steve Twiss
>>
>> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>>> one DA9063 and one DA9210 on Porter, the only difference from
>>> the other boards is that DA9063 is at I2C address 0x5a rather
>>> than 0x58 .
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>
>> Thanks for your patch!
>>
>>> --- a/arch/arm/boot/dts/r8a7791-porter.dts
>>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
>>> @@ -354,10 +354,47 @@
>>> clock-frequency = <400000>;
>>> };
>>>
>>> +&i2c6 {
>>> + status = "okay";
>>> + clock-frequency = <100000>;
>>> +
>>> + pmic@5a {
>>> + compatible = "dlg,da9063";
>>
>> Does it matter that this is a DA9063L ("Variant 6B")?
>> Do we need a new compatible value, or can this be detected at runtime?
>
> Hi Marek,
>
> could you follow up on this?
Yes, ASAP, once I'm back in the office, currently I'm stuck at the airport.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes
2018-02-18 15:07 ` Geert Uytterhoeven
2018-02-23 16:45 ` Simon Horman
@ 2018-02-24 22:11 ` Marek Vasut
2018-02-26 10:55 ` Simon Horman
1 sibling, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-02-24 22:11 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Kuninori Morimoto, Linux-Renesas,
Wolfram Sang, Steve Twiss, Simon Horman, linux-arm-kernel,
Marek Vasut
On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi,
> CC Steve Twiss
>
> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>> one DA9063 and one DA9210 on Porter, the only difference from
>> the other boards is that DA9063 is at I2C address 0x5a rather
>> than 0x58 .
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Thanks for your patch!
>
>> --- a/arch/arm/boot/dts/r8a7791-porter.dts
>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
>> @@ -354,10 +354,47 @@
>> clock-frequency = <400000>;
>> };
>>
>> +&i2c6 {
>> + status = "okay";
>> + clock-frequency = <100000>;
>> +
>> + pmic@5a {
>> + compatible = "dlg,da9063";
>
> Does it matter that this is a DA9063L ("Variant 6B")?
> Do we need a new compatible value, or can this be detected at runtime?
The driver detects it
da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)
Comparing the datasheets makes it obvious that 9063L is just a cut-down
version of 9063, with less LDOs and one less ADC. So I think we should
have extra compatible and have the driver restrict which LDOs can be
used with this smaller PMIC.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes
2018-02-24 22:11 ` Marek Vasut
@ 2018-02-26 10:55 ` Simon Horman
2018-02-26 11:15 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2018-02-26 10:55 UTC (permalink / raw)
To: Marek Vasut
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Kuninori Morimoto, Geert Uytterhoeven, Linux-Renesas,
Wolfram Sang, Geert Uytterhoeven, Steve Twiss, linux-arm-kernel,
Marek Vasut
On Sat, Feb 24, 2018 at 11:11:31PM +0100, Marek Vasut wrote:
> On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
> > Hi Marek,
>
> Hi,
>
> > CC Steve Twiss
> >
> > On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> >> one DA9063 and one DA9210 on Porter, the only difference from
> >> the other boards is that DA9063 is at I2C address 0x5a rather
> >> than 0x58 .
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >
> > Thanks for your patch!
> >
> >> --- a/arch/arm/boot/dts/r8a7791-porter.dts
> >> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> >> @@ -354,10 +354,47 @@
> >> clock-frequency = <400000>;
> >> };
> >>
> >> +&i2c6 {
> >> + status = "okay";
> >> + clock-frequency = <100000>;
> >> +
> >> + pmic@5a {
> >> + compatible = "dlg,da9063";
> >
> > Does it matter that this is a DA9063L ("Variant 6B")?
> > Do we need a new compatible value, or can this be detected at runtime?
>
> The driver detects it
>
> da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)
>
> Comparing the datasheets makes it obvious that 9063L is just a cut-down
> version of 9063, with less LDOs and one less ADC. So I think we should
> have extra compatible and have the driver restrict which LDOs can be
> used with this smaller PMIC.
Thanks, and sorry to ping yo about this while you were in transit.
It sounds like this patch should be updated.
Accordingly I'm marking it as "Changes Requested".
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes
2018-02-26 10:55 ` Simon Horman
@ 2018-02-26 11:15 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2018-02-26 11:15 UTC (permalink / raw)
To: Simon Horman
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Kuninori Morimoto, Geert Uytterhoeven, Linux-Renesas,
Wolfram Sang, Geert Uytterhoeven, Steve Twiss, linux-arm-kernel,
Marek Vasut
On 02/26/2018 11:55 AM, Simon Horman wrote:
> On Sat, Feb 24, 2018 at 11:11:31PM +0100, Marek Vasut wrote:
>> On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>> CC Steve Twiss
>>>
>>> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>>>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>>>> one DA9063 and one DA9210 on Porter, the only difference from
>>>> the other boards is that DA9063 is at I2C address 0x5a rather
>>>> than 0x58 .
>>>>
>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>>
>>> Thanks for your patch!
>>>
>>>> --- a/arch/arm/boot/dts/r8a7791-porter.dts
>>>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
>>>> @@ -354,10 +354,47 @@
>>>> clock-frequency = <400000>;
>>>> };
>>>>
>>>> +&i2c6 {
>>>> + status = "okay";
>>>> + clock-frequency = <100000>;
>>>> +
>>>> + pmic@5a {
>>>> + compatible = "dlg,da9063";
>>>
>>> Does it matter that this is a DA9063L ("Variant 6B")?
>>> Do we need a new compatible value, or can this be detected at runtime?
>>
>> The driver detects it
>>
>> da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)
>>
>> Comparing the datasheets makes it obvious that 9063L is just a cut-down
>> version of 9063, with less LDOs and one less ADC. So I think we should
>> have extra compatible and have the driver restrict which LDOs can be
>> used with this smaller PMIC.
>
> Thanks, and sorry to ping yo about this while you were in transit.
>
> It sounds like this patch should be updated.
> Accordingly I'm marking it as "Changes Requested".
Correct
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-02-26 11:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-17 2:07 [PATCH] ARM: dts: porter: Add missing PMIC nodes Marek Vasut
2018-02-18 15:07 ` Geert Uytterhoeven
2018-02-23 16:45 ` Simon Horman
2018-02-24 10:05 ` Marek Vasut
2018-02-24 22:11 ` Marek Vasut
2018-02-26 10:55 ` Simon Horman
2018-02-26 11:15 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).