From: Pavel Machek <pavel@ucw.cz>
To: Simon Shields <simon@lineageos.org>
Cc: linux-leds@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: leds: document Panasonic AN30259A bindings
Date: Wed, 21 Feb 2018 13:25:52 +0100 [thread overview]
Message-ID: <20180221122236.GB25848@amd> (raw)
In-Reply-To: <20180220005446.8577-2-simon@lineageos.org>
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
Hi!
> Signed-off-by: Simon Shields <simon@lineageos.org>
> ---
> .../devicetree/bindings/leds/leds-an30259a.txt | 41 ++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-an30259a.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-an30259a.txt b/Documentation/devicetree/bindings/leds/leds-an30259a.txt
> new file mode 100644
> index 000000000000..d3586ce71eef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-an30259a.txt
> @@ -0,0 +1,41 @@
> +* Panasonic AN30259A 3-channel LED driver
> +
> +The AN30259A is a LED controller capable of driving three LEDs independently. It supports
> +constant current output and sloping current output modes. The chip is connected over I2C.
> +
> +Required properties:
> + - compatible : must be "panasonic,an30259a"
> + - reg - I2C slave address
Might be nice to be consistent, you use 'label: explanation' below.
> +Each led is represented as a sub-node of the panasonic,an30259a node.
LED.
> +Optional sub-node properties:
> + - label: see Documentation/devicetree/bindings/leds/common.txt
> + - linux,default-trigger: see Documentation/devicetree/bindings/leds/common.txt
> + - led-sources: 0 if LED is connected to LED1 pin,
> + 1 if LED is connected to LED2 pin, or 2 if LED is connected to LED3 pin.
Normally, we use 'reg' for that, no?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-02-21 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 0:54 [PATCH 0/2] Panasonic AN30259A support Simon Shields
2018-02-20 0:54 ` [PATCH 1/2] dt-bindings: leds: document Panasonic AN30259A bindings Simon Shields
2018-02-20 21:28 ` Jacek Anaszewski
2018-02-21 19:35 ` Jacek Anaszewski
2018-02-21 12:25 ` Pavel Machek [this message]
2018-02-20 0:54 ` [PATCH 2/2] leds: add Panasonic AN30259A support Simon Shields
2018-02-20 21:51 ` Jacek Anaszewski
2018-02-21 14:18 ` Simon Shields
2018-02-21 19:55 ` Jacek Anaszewski
2018-02-21 12:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221122236.GB25848@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox