From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 16/25] arm: zx: dts: Remove leading 0x and 0s from bindings notation Date: Thu, 22 Feb 2018 10:19:44 +0800 Message-ID: <20180222021943.GA3217@dragon> References: <20171215124649.30692-1-malat@debian.org> <20171226080312.GE23070@X250> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Arnd Bergmann , Mathieu Malaterre , Russell King , "linux-kernel@vger.kernel.org" , Olof Johansson , Jun Nie , Baoyou Xie , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org On Tue, Feb 13, 2018 at 09:37:12AM -0600, Rob Herring wrote: > On Tue, Dec 26, 2017 at 2:03 AM, Shawn Guo wrote: > > On Fri, Dec 15, 2017 at 01:46:48PM +0100, Mathieu Malaterre wrote: > >> Improve the DTS files by removing all the leading "0x" and zeros to fix the > >> following dtc warnings: > >> > >> Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > >> > >> and > >> > >> Warning (unit_address_format): Node /XXX unit name should not have leading 0s > >> > >> Converted using the following command: > >> > >> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C > >> > >> For simplicity, two sed expressions were used to solve each warnings separately. > >> > >> To make the regex expression more robust a few other issues were resolved, > >> namely setting unit-address to lower case, and adding a whitespace before the > >> the opening curly brace: > >> > >> https://elinux.org/Device_Tree_Linux#Linux_conventions > >> > >> This will solve as a side effect warning: > >> > >> Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" > >> > >> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > >> > >> Reported-by: David Daney > >> Suggested-by: Rob Herring > >> Signed-off-by: Mathieu Malaterre > > > > Hi Arnd, Olof, > > > > I do not have any other ZTE ZX platform patches to send you. Is it okay > > to send this one using IMX branch, or can you apply it to arm-soc > > directly? > > Ping. This one didn't make it into 4.16. Sorry about that. I will send a pull request to arm-soc folks for this one, and hopefully it can still be merged for 4.16 as a fix. Shawn