devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quentin Perret <quentin.perret@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: DTML <devicetree@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	linux-pm@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Alexey Klimov <klimov.linux@gmail.com>,
	ALKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 19/20] cpufreq: add support for CPU DVFS based on SCMI message protocol
Date: Thu, 22 Feb 2018 09:04:04 +0000	[thread overview]
Message-ID: <20180222085936.GA2290@e108498-lin.cambridge.arm.com> (raw)
In-Reply-To: <1518461124-17371-20-git-send-email-sudeep.holla@arm.com>

Hi Sudeep,

On Monday 12 Feb 2018 at 18:45:23 (+0000), Sudeep Holla wrote:
[...]
> +/*
> + * perf_ops->freq_set is not a synchronous, the actual OPP change will
> + * happen asynchronously and can get notified if the events are
> + * subscribed for by the SCMI firmware
> + */
> +static int
> +scmi_cpufreq_set_target(struct cpufreq_policy *policy, unsigned int index)
> +{
> +	struct scmi_data *priv = policy->driver_data;
> +	struct scmi_perf_ops *perf_ops = handle->perf_ops;
> +	u64 freq = policy->freq_table[index].frequency * 1000;
> +
> +	return perf_ops->freq_set(handle, priv->domain_id, freq, false);
> +}

Is arch_set_freq_scale() needed in this function ?

Thanks,
Quentin

  reply	other threads:[~2018-02-22  9:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 18:45 [PATCH v5 00/20][RESEND] firmware: ARM System Control and Management Interface(SCMI) support Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 01/20] dt-bindings: mailbox: add support for mailbox client shared memory Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 02/20] dt-bindings: arm: add support for ARM System Control and Management Interface(SCMI) protocol Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 04/20] firmware: arm_scmi: add common infrastructure and support for base protocol Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 05/20] firmware: arm_scmi: add scmi protocol bus to enumerate protocol devices Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 06/20] firmware: arm_scmi: add initial support for performance protocol Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 07/20] firmware: arm_scmi: add initial support for clock protocol Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 10/20] firmware: arm_scmi: probe and initialise all the supported protocols Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 11/20] firmware: arm_scmi: add support for polling based SCMI transfers Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 12/20] firmware: arm_scmi: add option for polling based performance domain operations Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 14/20] firmware: arm_scmi: add per-protocol channels support using idr objects Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 16/20] clk: add support for clocks provided by SCMI Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 17/20] hwmon: (core) Add hwmon_max to hwmon_sensor_types enumeration Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 18/20] hwmon: add support for sensors exported via ARM SCMI Sudeep Holla
2018-02-12 18:45 ` [PATCH v5 20/20] cpufreq: scmi: add support for fast frequency switching Sudeep Holla
     [not found] ` <1518461124-17371-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2018-02-12 18:45   ` [PATCH v5 08/20] firmware: arm_scmi: add initial support for power protocol Sudeep Holla
2018-02-12 18:45   ` [PATCH v5 09/20] firmware: arm_scmi: add initial support for sensor protocol Sudeep Holla
2018-02-12 18:45   ` [PATCH v5 13/20] firmware: arm_scmi: refactor in preparation to support per-protocol channels Sudeep Holla
2018-02-12 18:45   ` [PATCH v5 15/20] firmware: arm_scmi: add device power domain support using genpd Sudeep Holla
2018-02-12 18:45   ` [PATCH v5 19/20] cpufreq: add support for CPU DVFS based on SCMI message protocol Sudeep Holla
2018-02-22  9:04     ` Quentin Perret [this message]
2018-02-22  9:48       ` Sudeep Holla
2018-02-15  0:09   ` [PATCH v5 00/20][RESEND] firmware: ARM System Control and Management Interface(SCMI) support Alexey Klimov
     [not found]     ` <CALW4P+LPiYSOCKW4iS6OwK9S=M3aCP+X6QNnDkycY5TYQsCb5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-15  9:59       ` Sudeep Holla
  -- strict thread matches above, loose matches on Subject: below --
2018-01-02 14:42 [PATCH v5 00/20] " Sudeep Holla
2018-01-02 14:42 ` [PATCH v5 19/20] cpufreq: add support for CPU DVFS based on SCMI message protocol Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222085936.GA2290@e108498-lin.cambridge.arm.com \
    --to=quentin.perret@arm.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=klimov.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).