devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec
Date: Fri, 23 Feb 2018 09:07:14 +0100	[thread overview]
Message-ID: <20180223080714.GC1584@amd> (raw)
In-Reply-To: <20180216142716.GJ5886@sirena.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]

On Fri 2018-02-16 14:27:16, Mark Brown wrote:
> On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote:
> > On Fri, Feb 16, 2018 at 11:39:01AM +0000, Mark Brown wrote:
> 
> > > We don't have default lines like this for other MFDs...
> 
> > Is there a reason not to add them? It looks very useful to me:
> 
> Consistency.  It's a lot easier to apply a single rule to everything
> than it is to have to individually think through and discuss the
> decisions on every individual driver, especially when there will
> inevitably be some cases where there are conflicting requirements from
> different users.  As you said in the rest of your mail hand configuring
> kernels is already a very specialist thing at the best of times.

Yes, so please don't make it any harder than it needs to be. Having to
enable (by hand) more than one option per chip is annoying and error-prone.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2018-02-23  8:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 22:07 [PATCHv4 0/4] Motorola Droid 4 Audio Support Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Sebastian Reichel
2018-02-16 11:30   ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown
     [not found]     ` <20180216113008.GB5886-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-16 13:25       ` Sebastian Reichel
2018-02-16 13:44         ` Mark Brown
2018-02-16 14:12           ` Sebastian Reichel
2018-02-16 15:16             ` Mark Brown
2018-02-16 15:57               ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Tony Lindgren
2018-02-19 13:05                 ` Mark Brown
2018-02-22 19:54                   ` Tony Lindgren
2018-02-23 12:47                     ` Sebastian Reichel
2018-02-16 15:58               ` [PATCHv4 1/4] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2018-02-19 13:25                 ` [PATCHv4 1/4] dt-bindings: sound: add motorola, cpcap-audio-codec Mark Brown
2018-02-14 22:07 ` [PATCHv4 2/4] ASoC: codec: cpcap: new codec Sebastian Reichel
     [not found]   ` <20180214220741.28306-3-sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2018-02-15  9:50     ` Philippe Ombredanne
2018-02-16 13:31       ` Sebastian Reichel
2018-02-16 11:39   ` Mark Brown
2018-02-16 13:51     ` Sebastian Reichel
     [not found]       ` <20180216135113.akicejkodhbjpp2w-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2018-02-16 14:27         ` Mark Brown
2018-02-23  8:07           ` Pavel Machek [this message]
2018-02-23 12:44             ` Sebastian Reichel
2018-02-14 22:07 ` [PATCHv4 3/4] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
     [not found] ` <20180214220741.28306-1-sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2018-02-14 22:07   ` [PATCHv4 4/4] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223080714.GC1584@amd \
    --to=pavel@ucw.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.reichel@collabora.co.uk \
    --cc=tiwai@suse.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).