From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 23 Feb 2018 23:45:46 +0100 From: Boris Brezillon Subject: Re: [PATCH v2 2/7] i3c: Add core I3C infrastructure Message-ID: <20180223234546.54e62150@bbrezillon> In-Reply-To: References: <20171214151610.19153-1-boris.brezillon@free-electrons.com> <20171214151610.19153-3-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: Vitor Soares Cc: Boris Brezillon , Wolfram Sang , linux-i2c@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann , Przemyslaw Sroka , Arkadiusz Golec , Alan Douglas , Bartosz Folta , Damian Kos , Alicja Jurasik-Urbaniak , Cyprian Wronka , Suresh Punnoose , Thomas Petazzoni , Nishanth Menon , "Rob Herring , Pawel Moll , Mark Rutland" , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Linus Walleij List-ID: On Fri, 23 Feb 2018 16:56:14 +0000 Vitor Soares wrote: > > + > > +/** > > + * struct i3c_ccc_setda - payload passed to ENTTM CCC > > + * > > + * @mode: one of the &enum i3c_ccc_test_mode modes > > + * > > + * Information passed to the ENTTM CCC to instruct an I3C device to en= ter a > > + * specific test mode. Oops, copy&paste error. I'll fix the kernel-doc header. > > + */ > > +struct i3c_ccc_setda { > > + u8 addr; > > +} __packed; =20 >=20 > =C2=A0what do you mean with struct? Maybe setdasa? if so, what is the add= r? It's the payload passed to SETDASA and SETNEWDA, hence the generic _setda suffix. addr is the new dynamic address assigned to the device. --=20 Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com