* [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells
@ 2018-02-23 11:07 Fabrice Gasnier
2018-02-23 13:46 ` Arnaud Pouliquen
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Gasnier @ 2018-02-23 11:07 UTC (permalink / raw)
To: jic23, robh+dt
Cc: mark.rutland, devicetree, benjamin.gaignard, lars,
alexandre.torgue, linux-iio, pmeerw, arnaud.pouliquen, linux,
linux-kernel, mcoquelin.stm32, knaack.h, fabrice.gasnier,
linux-arm-kernel
io-channel-cells should be <0> since sigma delta modulator exports only
one channel, as described in ../iio/iio-bindings.txt "IIO providers"
section. Only the phandle is necessary for IIO consumers in this case.
Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
index e9ebb8a..ba24ca7 100644
--- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
+++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
@@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator
Required properties:
- compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
as a generic SD modulator if modulator not specified in compatible list.
-- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
+- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
Example node:
ads1202: adc@0 {
compatible = "sd-modulator";
- #io-channel-cells = <1>;
+ #io-channel-cells = <0>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells
2018-02-23 11:07 [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells Fabrice Gasnier
@ 2018-02-23 13:46 ` Arnaud Pouliquen
2018-02-24 13:28 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Arnaud Pouliquen @ 2018-02-23 13:46 UTC (permalink / raw)
To: Fabrice Gasnier, jic23, robh+dt
Cc: mark.rutland, devicetree, benjamin.gaignard, lars,
alexandre.torgue, linux-iio, pmeerw, linux, linux-kernel,
mcoquelin.stm32, knaack.h, linux-arm-kernel
Hello,
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Regards,
Arnaud
On 02/23/2018 12:07 PM, Fabrice Gasnier wrote:
> io-channel-cells should be <0> since sigma delta modulator exports only
> one channel, as described in ../iio/iio-bindings.txt "IIO providers"
> section. Only the phandle is necessary for IIO consumers in this case.
>
> Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> index e9ebb8a..ba24ca7 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> @@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator
> Required properties:
> - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
> as a generic SD modulator if modulator not specified in compatible list.
> -- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
> +- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
>
> Example node:
>
> ads1202: adc@0 {
> compatible = "sd-modulator";
> - #io-channel-cells = <1>;
> + #io-channel-cells = <0>;
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells
2018-02-23 13:46 ` Arnaud Pouliquen
@ 2018-02-24 13:28 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2018-02-24 13:28 UTC (permalink / raw)
To: Arnaud Pouliquen
Cc: mark.rutland, devicetree, benjamin.gaignard, lars,
alexandre.torgue, linux-iio, pmeerw, linux, linux-kernel, robh+dt,
mcoquelin.stm32, knaack.h, Fabrice Gasnier, linux-arm-kernel
On Fri, 23 Feb 2018 14:46:19 +0100
Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote:
> Hello,
>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> Regards,
> Arnaud
>
> On 02/23/2018 12:07 PM, Fabrice Gasnier wrote:
> > io-channel-cells should be <0> since sigma delta modulator exports only
> > one channel, as described in ../iio/iio-bindings.txt "IIO providers"
> > section. Only the phandle is necessary for IIO consumers in this case.
> >
> > Fixes: af11143757b7 ("IIO: Add DT bindings for sigma delta adc modulator")
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> > index e9ebb8a..ba24ca7 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> > @@ -3,11 +3,11 @@ Device-Tree bindings for sigma delta modulator
> > Required properties:
> > - compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
> > as a generic SD modulator if modulator not specified in compatible list.
> > -- #io-channel-cells = <1>: See the IIO bindings section "IIO consumers".
> > +- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
> >
> > Example node:
> >
> > ads1202: adc@0 {
> > compatible = "sd-modulator";
> > - #io-channel-cells = <1>;
> > + #io-channel-cells = <0>;
> > };
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-24 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 11:07 [PATCH] dt-bindings: iio: adc: sd-modulator: fix io-channel-cells Fabrice Gasnier
2018-02-23 13:46 ` Arnaud Pouliquen
2018-02-24 13:28 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).