From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4
Date: Wed, 28 Feb 2018 19:46:10 -0800 [thread overview]
Message-ID: <20180301034610.GC62820@atomide.com> (raw)
In-Reply-To: <20180219204029.xrftbbxvdfxlf7jh@rob-hp-laptop>
* Rob Herring <robh@kernel.org> [180219 20:41]:
> On Sat, Feb 17, 2018 at 01:07:23PM -0800, Tony Lindgren wrote:
> > The GPIOs controlling MDM6600 are used to power MDM660 on and off, to
>
> MDM660 a typo?
Thanks fixing.
> > +Required properties:
> > +- compatible Must be "motorola,mapphone-mdm6600"
> > +- enable-gpios GPIO to enable the USB PHY
> > +- power-gpios GPIO to power on the device
> > +- reset-gpios GPIO to reset the device
>
> The are pretty standard, but...
>
> > +- mode-gpios Two GPIOs to configure MDM6600 USB start-up mode for
> > + normal mode versus USB flashing mode
> > +- status-gpios Three GPIOs to read the power state of the MDM6600
> > +- cmd-gpios Three GPIOs to control the power state of the MDM6600
>
> These 3 should have vendor a prefix.
OK
> > +
> > +Example:
> > +
> > +fsusb1_phy: fsusb1_phy {
>
> usb-phy {
Thanks will send out an updated version shortly.
Regards,
Tony
prev parent reply other threads:[~2018-03-01 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 21:07 [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Tony Lindgren
2018-02-18 0:31 ` Sebastian Reichel
2018-02-18 17:50 ` Tony Lindgren
2018-02-19 7:45 ` kbuild test robot
2018-03-01 3:47 ` Tony Lindgren
2018-02-19 20:40 ` Rob Herring
2018-03-01 3:46 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301034610.GC62820@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).