From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
arm@kernel.org, "Benoît Cousson" <bcousson@baylibre.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: dts: omap3: Add missing #sound-dai-cells
Date: Thu, 1 Mar 2018 14:32:43 -0800 [thread overview]
Message-ID: <20180301223243.GI62820@atomide.com> (raw)
In-Reply-To: <20180301202537.30571-2-robh@kernel.org>
* Rob Herring <robh@kernel.org> [180301 12:26]:
> dtc now gives the following warnings:
>
> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp@68000000/mcbsp@49026000 or bad phandle (referred from sound-dai[0])
>
> Add the missing #sound-dai-cells property.
Is this needed for the current -rc or is v4.17 OK?
Somehow I'm not seeing these with current -rc or next, is
there some special option (not W=2 :) that you're using?
Regards,
Tony
> Cc: "Benoît Cousson" <bcousson@baylibre.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/omap3.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index a005802cd52b..4043ecb38016 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -557,6 +557,7 @@
> dma-names = "tx", "rx";
> clocks = <&mcbsp4_fck>;
> clock-names = "fck";
> + #sound-dai-cells = <0>;
> status = "disabled";
> };
>
> --
> 2.14.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-03-01 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 20:25 [PATCH] arm: dts: omap3: Add missing #sound-dai-cells Rob Herring
2018-03-01 22:32 ` Tony Lindgren [this message]
2018-03-01 23:28 ` Rob Herring
2018-03-01 23:33 ` Tony Lindgren
2018-03-05 19:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301223243.GI62820@atomide.com \
--to=tony@atomide.com \
--cc=arm@kernel.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).