devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Tony Lindgren <tony@atomide.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	kishon@ti.com, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/11] mmc: sdhci-omap: Fix when capabilities are obtained from SDHCI_CAPABILITIES reg
Date: Wed, 7 Mar 2018 18:50:10 +0530	[thread overview]
Message-ID: <20180307132020.30951-2-kishon@ti.com> (raw)
In-Reply-To: <20180307132020.30951-1-kishon@ti.com>

sdhci_omap_config_iodelay_pinctrl_state() requires caps and caps2 to be
initialized (speed mode capabilities like UHS/HS200) before it is
invoked. While mmc_of_parse() initializes caps/caps2 if capabilities is
populated in device tree, it will remain uninitialized for capabilities
obtained from SDHCI_CAPABILITIES register.
Fix sdhci_omap_config_iodelay_pinctrl_state() to be used even while
getting the capabilities from SDHCI_CAPABILITIES register by invoking
sdhci_setup_host() before sdhci_omap_config_iodelay_pinctrl_state().

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/mmc/host/sdhci-omap.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 1456abd5eeb9..3cce30584d2f 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -916,10 +916,6 @@ static int sdhci_omap_probe(struct platform_device *pdev)
 		goto err_put_sync;
 	}
 
-	ret = sdhci_omap_config_iodelay_pinctrl_state(omap_host);
-	if (ret)
-		goto err_put_sync;
-
 	host->mmc_host_ops.get_ro = mmc_gpio_get_ro;
 	host->mmc_host_ops.start_signal_voltage_switch =
 					sdhci_omap_start_signal_voltage_switch;
@@ -930,7 +926,15 @@ static int sdhci_omap_probe(struct platform_device *pdev)
 	sdhci_read_caps(host);
 	host->caps |= SDHCI_CAN_DO_ADMA2;
 
-	ret = sdhci_add_host(host);
+	ret = sdhci_setup_host(host);
+	if (ret)
+		goto err_put_sync;
+
+	ret = sdhci_omap_config_iodelay_pinctrl_state(omap_host);
+	if (ret)
+		goto err_put_sync;
+
+	ret = __sdhci_add_host(host);
 	if (ret)
 		goto err_put_sync;
 
-- 
2.11.0

  reply	other threads:[~2018-03-07 13:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 13:20 [PATCH v3 00/11] mmc: sdhci-omap: Add UHS/HS200 mode support Kishon Vijay Abraham I
2018-03-07 13:20 ` Kishon Vijay Abraham I [this message]
2018-03-15 14:17   ` [PATCH v3 01/11] mmc: sdhci-omap: Fix when capabilities are obtained from SDHCI_CAPABILITIES reg Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 02/11] mmc: sdhci-omap: Remove setting ADMA capability in driver Kishon Vijay Abraham I
2018-03-15 14:18   ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 03/11] mmc: sdhci-omap: Workaround for Errata i843 Kishon Vijay Abraham I
2018-03-15 14:24   ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 04/11] mmc: sdhci-omap: Invoke sdhci_get_of_property to read sdhci dt properties Kishon Vijay Abraham I
2018-03-15 14:27   ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 05/11] mmc: sdhci: Disable HS200 mode if controller can't support 1.8v Kishon Vijay Abraham I
2018-03-15 10:58   ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 06/11] mmc: sdhci: Add quirk to disable HW timeout Kishon Vijay Abraham I
2018-03-15 11:26   ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 07/11] mmc: sdhci: Program a relatively accurate SW timeout value Kishon Vijay Abraham I
2018-03-15 13:13   ` Adrian Hunter
2018-03-16  6:29     ` Kishon Vijay Abraham I
2018-03-16 14:21       ` Adrian Hunter
2018-03-19  9:20         ` Kishon Vijay Abraham I
2018-03-19 10:00           ` Adrian Hunter
2018-03-19 10:19             ` Kishon Vijay Abraham I
2018-03-20  9:48               ` Kishon Vijay Abraham I
2018-04-04 12:48                 ` Adrian Hunter
2018-03-07 13:20 ` [PATCH v3 08/11] mmc: sdhci-omap: Workaround for Errata i834 Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 09/11] dt-bindings: sdhci-omap: Add K2G specific binding Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 10/11] mmc: sdhci-omap: Add support for MMC/SD controller in k2g SoC Kishon Vijay Abraham I
2018-03-07 13:20 ` [PATCH v3 11/11] mmc: sdhci-omap: Add sdhci_omap specific ops for enable_sdio_irq Kishon Vijay Abraham I
2018-03-15 14:34   ` Adrian Hunter
2018-03-07 15:12 ` [PATCH v3 00/11] mmc: sdhci-omap: Add UHS/HS200 mode support Tony Lindgren
2018-03-15  8:47 ` Ulf Hansson
2018-03-15  8:52   ` Adrian Hunter
2018-03-15 10:02     ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307132020.30951-2-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=adrian.hunter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).