From: Pavel Machek <pavel@ucw.cz>
To: Simon Shields <simon@lineageos.org>
Cc: linux-leds@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: document Panasonic AN30259A bindings
Date: Wed, 7 Mar 2018 22:58:36 +0100 [thread overview]
Message-ID: <20180307215836.GB10438@amd> (raw)
In-Reply-To: <20180307004722.23524-2-simon@lineageos.org>
[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]
On Wed 2018-03-07 11:47:21, Simon Shields wrote:
> Signed-off-by: Simon Shields <simon@lineageos.org>
Well, single line for a changelog would not hurt :-).
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> .../devicetree/bindings/leds/leds-an30259a.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-an30259a.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-an30259a.txt b/Documentation/devicetree/bindings/leds/leds-an30259a.txt
> new file mode 100644
> index 000000000000..34ad4b189853
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-an30259a.txt
> @@ -0,0 +1,43 @@
> +* Panasonic AN30259A 3-channel LED driver
> +
> +The AN30259A is a LED controller capable of driving three LEDs independently. It supports
> +constant current output and sloping current output modes. The chip is connected over I2C.
> +
> +Required properties:
> + - compatible: Must be "panasonic,an30259a".
> + - reg: I2C slave address.
> + - #address-cells: Must be 1.
> + - #size-cells: Must be 0.
> +
> +Each LED is represented as a sub-node of the panasonic,an30259a node.
> +
> +Required sub-node properties:
> + - reg: Pin that the LED is connected to. Must be 1, 2, or 3.
> +
> +Optional sub-node properties:
> + - label: see Documentation/devicetree/bindings/leds/common.txt
> + - linux,default-trigger: see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +leds@30 {
> + compatible = "panasonic,an30259a";
> + reg = <0x30>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@1 {
> + reg = <1>;
> + linux,default-trigger = "heartbeat";
> + label = "an30259a:red:notification";
> + };
> +
> + led@2 {
> + reg = <2>;
> + label = "an30259a:green:notification";
> + };
> +
> + led@3 {
> + reg = <3>;
> + label = "an30259a:blue:notification";
> + };
> +};
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-07 21:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 0:47 [PATCH v2 0/2] Panasonic AN30259A support Simon Shields
2018-03-07 0:47 ` [PATCH v2 1/2] dt-bindings: leds: document Panasonic AN30259A bindings Simon Shields
2018-03-07 21:58 ` Pavel Machek [this message]
2018-03-08 2:02 ` Rob Herring
2018-03-08 22:17 ` Jacek Anaszewski
2018-03-08 22:54 ` Pavel Machek
2018-03-09 22:33 ` Jacek Anaszewski
2018-03-07 0:47 ` [PATCH v2 2/2] leds: add Panasonic AN30259A support Simon Shields
2018-03-07 22:07 ` Pavel Machek
2018-03-08 0:48 ` Simon Shields
2018-03-08 22:17 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307215836.GB10438@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).