From: Shawn Guo <shawn.guo@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Jianguo Sun <sunjianguo1@huawei.com>,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengcheng Li <lpc.li@hisilicon.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: add bindings doc for HiSilicon INNO USB2 PHY
Date: Thu, 8 Mar 2018 09:32:11 +0800 [thread overview]
Message-ID: <20180308013208.GJ28619@dragon> (raw)
In-Reply-To: <20180307211118.su2vyfa4zyfh4w2t@rob-hp-laptop>
On Wed, Mar 07, 2018 at 03:11:18PM -0600, Rob Herring wrote:
> > +Example:
> > +
> > +perictrl: peripheral-controller@8a20000 {
> > + compatible = "hisilicon,hi3798cv200-perictrl", "syscon",
> > + "simple-mfd";
>
> Is syscon needed here? Doesn't look like the phys need it.
For phys, "syscon" is not needed, but there are other devices to be
added which will need to access perictrl as syscon. Anyway, I can drop
"syscon" from the example in this bindings doc to avoid the confusion.
> Is there no dependency on the peri ctrl probing first for the phys to
> probe successfully? If there is some dependency, simple-mfd should not
> be used.
No, there is no such dependency. Right now the perictrl is there only
for populating the phy devcies.
> As for the phy binding,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Thanks.
Shawn
next prev parent reply other threads:[~2018-03-08 1:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 2:40 [PATCH v4 0/2] Add HiSilicon INNO USB2 PHY driver support Shawn Guo
2018-03-05 2:40 ` [PATCH v4 1/2] dt-bindings: add bindings doc for HiSilicon INNO USB2 PHY Shawn Guo
2018-03-07 21:11 ` Rob Herring
2018-03-08 1:32 ` Shawn Guo [this message]
2018-03-05 2:40 ` [PATCH v4 2/2] phy: add inno-usb2-phy driver for hi3798cv200 SoC Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308013208.GJ28619@dragon \
--to=shawn.guo@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lpc.li@hisilicon.com \
--cc=robh@kernel.org \
--cc=sunjianguo1@huawei.com \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).