From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v2] arm64: dts: msm8916: Add cpu cooling maps Date: Thu, 8 Mar 2018 10:28:26 +0530 Message-ID: <20180308045826.GE6842@vireshk-i7> References: <9f7199f0027ef2382e5ccc61a5118d0a00fa2e63.1520340931.git.amit.kucheria@linaro.org> <4d134dee2154ae3fa56b375aaed9568e21b1a777.1520398076.git.amit.kucheria@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Amit Kucheria Cc: Mark Rutland , DTML , Rajendra Nayak , linux-arm-msm , Will Deacon , Linux Kernel Mailing List , David Brown , Rob Herring , Catalin Marinas , Andy Gross , "open list:ARM/QUALCOMM SUPPORT" , Linux ARM List-Id: devicetree@vger.kernel.org On 07-03-18, 16:56, Amit Kucheria wrote: > On Wed, Mar 7, 2018 at 10:44 AM, Viresh Kumar wrote: > > On Wed, Mar 7, 2018 at 10:30 AM, Amit Kucheria wrote: > >> From: Rajendra Nayak > >> > >> Add cpu cooling maps for cpu passive trip points. The cpu cooling > >> device states are mapped to cpufreq based scaling frequencies. > >> > >> Signed-off-by: Rajendra Nayak > >> Signed-off-by: Amit Kucheria > >> --- > >> arch/arm64/boot/dts/qcom/msm8916.dtsi | 19 +++++++++++++++++++ > >> 1 file changed, 19 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi > >> index e468277..66b318e 100644 > >> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > >> @@ -15,6 +15,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> / { > >> model = "Qualcomm Technologies, Inc. MSM8916"; > >> @@ -115,6 +116,7 @@ > >> cpu-idle-states = <&CPU_SPC>; > >> clocks = <&apcs 0>; > >> operating-points-v2 = <&cpu_opp_table>; > >> + #cooling-cells = <2>; > > > > LGTM. > > Can I take that as a Reviewed-by? Sure. Reviewed-by: Viresh Kumar -- viresh