From: Christoph Hellwig <hch@lst.de>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"stuyoder@gmail.com" <stuyoder@gmail.com>,
Bharat Bhushan <bharat.bhushan@nxp.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infra>
Subject: Re: [PATCH 5/6] dma-mapping: support fsl-mc bus
Date: Thu, 8 Mar 2018 08:41:15 +0100 [thread overview]
Message-ID: <20180308074115.GB15748@lst.de> (raw)
In-Reply-To: <HE1PR0401MB24251E99564CAA526F719ECCE6D90@HE1PR0401MB2425.eurprd04.prod.outlook.com>
On Tue, Mar 06, 2018 at 04:41:56AM +0000, Nipun Gupta wrote:
> Sorry for asking a trivial question - looking into dma_configure() I see that
> PCI is used in the start and the end of the API.
> In the end part pci_put_host_bridge_device() is called.
> So are two bus callbacks something like 'dma_config_start' & 'dma_config_end'
> will be required where the former one will return "dma_dev"?
I'd just use dma_configure as the callback.
Currently the of_dma_configure and acpi_dma_configure are only used
for PCI anyway, as no one else sets a non-NULL dma dev. For fsl-mc
I suspect only of_dma_configure is relevanet, so just call that directly.
If at some point we get enough busses with either OF or ACPI we could
create a helper called from ->dma_configure for that.
next prev parent reply other threads:[~2018-03-08 7:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 14:29 [PATCH 0/6] Support for fsl-mc bus and its devices in SMMU Nipun Gupta
[not found] ` <1520260166-29387-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-05 14:29 ` [PATCH 1/6] Docs: dt: add fsl-mc iommu-parent device-tree binding Nipun Gupta
2018-03-05 14:53 ` Robin Murphy
2018-03-05 15:00 ` Nipun Gupta
[not found] ` <HE1PR0401MB24254CBDB8B6F537D08B925DE6DA0-B0v07Ae2taqTjcJO+iVGAo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-03-05 15:37 ` Robin Murphy
2018-03-05 15:54 ` Nipun Gupta
[not found] ` <1520260166-29387-2-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-03-07 22:40 ` Rob Herring
2018-03-08 12:32 ` Nipun Gupta
2018-03-05 14:29 ` [PATCH 2/6] iommu: support iommu configuration for fsl-mc devices Nipun Gupta
2018-03-05 14:29 ` [PATCH 3/6] iommu: arm-smmu: Add support for the fsl-mc bus Nipun Gupta
2018-03-05 14:29 ` [PATCH 4/6] bus: fsl-mc: remove dma ops setup from driver Nipun Gupta
2018-03-05 14:29 ` [PATCH 5/6] dma-mapping: support fsl-mc bus Nipun Gupta
2018-03-05 15:08 ` Christoph Hellwig
[not found] ` <20180305150814.GA15918-jcswGhMUV9g@public.gmane.org>
2018-03-05 15:48 ` Robin Murphy
[not found] ` <7b4f9972-6aaa-fc9d-3854-d48b19a8051c-5wv7dgnIgG8@public.gmane.org>
2018-03-05 18:39 ` Christoph Hellwig
[not found] ` <20180305183938.GB20086-jcswGhMUV9g@public.gmane.org>
2018-03-05 18:51 ` Robin Murphy
2018-03-06 4:41 ` Nipun Gupta
2018-03-08 7:41 ` Christoph Hellwig [this message]
[not found] ` <20180308074115.GB15748-jcswGhMUV9g@public.gmane.org>
2018-03-09 18:29 ` Nipun Gupta
[not found] ` <HE1PR0401MB2425871215B13AD0EFDCA5C3E6DE0-B0v07Ae2taqTjcJO+iVGAo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-03-09 18:50 ` Robin Murphy
2018-03-05 14:29 ` [PATCH 6/6] dts: fsl-ls208x: updated DT with SMMU support for fsl-mc Nipun Gupta
2018-04-17 10:21 ` [PATCH 0/6 v2] Support for fsl-mc bus and its devices in SMMU Nipun Gupta
[not found] ` <1523960514-25457-1-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-04-17 10:21 ` [PATCH 1/6 v2] Docs: dt: add fsl-mc iommu-map device-tree binding Nipun Gupta
2018-04-17 10:21 ` [PATCH 2/6 v2] iommu: of: make of_pci_map_rid() available for other devices too Nipun Gupta
[not found] ` <1523960514-25457-3-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-04-17 16:52 ` Robin Murphy
[not found] ` <41b32766-e21a-e946-6c8f-440e5c87d0ee-5wv7dgnIgG8@public.gmane.org>
2018-04-18 5:09 ` Bharat Bhushan
2018-04-18 6:21 ` Nipun Gupta
2018-04-17 10:21 ` [PATCH 3/6 v2] iommu: support iommu configuration for fsl-mc devices Nipun Gupta
2018-04-17 10:21 ` [PATCH 4/6 v2] iommu: arm-smmu: Add support for the fsl-mc bus Nipun Gupta
2018-04-17 10:21 ` [PATCH 5/6 v2] bus: fsl-mc: supoprt dma configure for devices on " Nipun Gupta
[not found] ` <1523960514-25457-6-git-send-email-nipun.gupta-3arQi8VN3Tc@public.gmane.org>
2018-04-26 0:00 ` kbuild test robot
2018-04-17 10:21 ` [PATCH 6/6 v2] arm64: dts: ls208xa: comply with the iommu map binding for fsl_mc Nipun Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308074115.GB15748@lst.de \
--to=hch@lst.de \
--cc=bharat.bhushan@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infra \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nipun.gupta@nxp.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=shawnguo@kernel.org \
--cc=stuyoder@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).