From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec Date: Thu, 8 Mar 2018 16:33:01 +0800 Message-ID: <20180308083300.GU3217@dragon> References: <20180301202537.30571-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180301202537.30571-1-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Fabio Estevam , devicetree@vger.kernel.org, arm@kernel.org, Sascha Hauer , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, Mar 01, 2018 at 02:25:33PM -0600, Rob Herring wrote: > dtc now warns about missing #sound-dai-cells: > > arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0]) > arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0]) > arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0]) > > Lots of i.MX boards use the SGTL5000 codec, but not all get the warning > because only some reference the codec with "sound-dai" property. However, > the codec should always provide #sound-dai-cells regardless, so fix all > the occurrences. > > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Fabio Estevam > Signed-off-by: Rob Herring Applied, thanks.