Re: [PATCH v2 0/2] drm/panel: Add support for Raydium RM68200 panel

From: Thierry Reding <thierry.reding@gmail.com>
To: Philippe Cornu <philippe.cornu@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Alexandre Torgue <alexandre.torgue@st.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Yannick Fertre <yannick.fertre@st.com>,
	Rob Herring <robh+dt@kernel.org>,
	Vincent Abriou <vincent.abriou@st.com>
Subject: Re: [PATCH v2 0/2] drm/panel: Add support for Raydium RM68200 panel
Date: Mon, 12 Mar 2018 09:04:04 +0100	[thread overview]
Message-ID: <20180312080404.GE23060@ulmo> (raw)
In-Reply-To: <20180302153222.4377-1-philippe.cornu@st.com>

[-- Attachment #1.1: Type: text/plain, Size: 1703 bytes --]

On Fri, Mar 02, 2018 at 04:32:20PM +0100, Philippe Cornu wrote:
> The Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280
> TFT LCD panel connected using a MIPI-DSI video interface.
> 
> Version 2:
> - Add Rob Herring Reviewed-by on dt-bindings.
> - Update Kconfig & driver thanks to Thierry Reding comments: no more
>   DRV_NAME, DRM_WARN_ONCE instead of DRV_NAME where applicable, use
>   backlight_enable/disable() & devm_of_find_backlight(), no extra
>   gpio reset to 0, no more msg if successful, use RM68200 instead of
>   rm68200 where necessary.
> 
> Version 1:
> - Initial commit
> 
> Philippe Cornu (2):
>   dt-bindings/display/panel: Add support for Raydium rm68200 dsi panel
>   drm/panel: Add support for Raydium RM68200 panel driver
> 
>  .../bindings/display/panel/raydium,rm68200.txt     |  25 ++
>  drivers/gpu/drm/panel/Kconfig                      |   8 +
>  drivers/gpu/drm/panel/Makefile                     |   1 +
>  drivers/gpu/drm/panel/panel-raydium-rm68200.c      | 437 +++++++++++++++++++++
>  4 files changed, 471 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm68200.txt
>  create mode 100755 drivers/gpu/drm/panel/panel-raydium-rm68200.c

Applied, thanks. There were a few tiny things I wasn't entirely happy
about, but I fixed those up myself.

Most notable was the use of DRM_WARN_ONCE(), which is bad in this case
because it won't show any subsequent errors, ever again. I think in this
case the proper solution is DRM_ERROR_RATELIMITED(), or erroring out on
the first error, assuming that subsequent operations won't succeed
either. I went with the rate limitation.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel