From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Harald Geyer <harald@ccbib.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, info@olimex.com,
"André Przywara" <andre.przywara@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, "Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
"Icenowy Zheng" <icenowy@aosc.io>
Subject: Re: [PATCH 1/5] arm64: dts: allwinner: a64: Add i2c0 pins
Date: Tue, 13 Mar 2018 16:27:44 +0100 [thread overview]
Message-ID: <20180313152744.fb2oo44v6lr4gyha@flea> (raw)
In-Reply-To: <E1evfa8-0000O7-0e@stardust.g4.wien.funkfeuer.at>
[-- Attachment #1.1: Type: text/plain, Size: 1290 bytes --]
On Tue, Mar 13, 2018 at 09:46:51AM +0100, Harald Geyer wrote:
> André Przywara writes:
> > On 12/03/18 16:10, Harald Geyer wrote:
> > > Add the proper pin group node to reference in board files.
> > >
> > > Signed-off-by: Harald Geyer <harald@ccbib.org>
> >
> > That looks correct to me, so:
> >
> > Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> >
> > But out of curiosity, what is this used for? In patch 5/5 I see it being
> > used, but without a clue for what? Shouldn't enabling an I2C node be
> > accompanied by some child node, presenting the device on the bus?
> > I guess this I2C is not on some kind of "header" on that laptop?
>
> I enabled it because the ANX6345 eDP-bridge is on that bus. There is
> no linux (mainline) driver for this chip at the moment, the bootloader
> initializes it. However I'm using the i2c-dev driver to read (and maybe)
> change some register values from user space.
>
> i2cdetect sees devices at 0x38, 0x39 and 0x3d - all of which might
> be the ANX6345. I haven't looked into this in detail.
That's alright then, just put a comment in the DT on what this bus is
used for.
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-03-13 15:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 16:10 arm64: allwinner: Add support for TERES I laptop Harald Geyer
2018-03-12 16:10 ` [PATCH 1/5] arm64: dts: allwinner: a64: Add i2c0 pins Harald Geyer
2018-03-13 1:35 ` André Przywara
2018-03-13 8:46 ` Harald Geyer
2018-03-13 15:27 ` Maxime Ripard [this message]
2018-03-12 16:10 ` [PATCH 2/5] arm64: dts: allwinner: a64: Add watchdog Harald Geyer
2018-03-13 1:39 ` André Przywara
2018-03-13 10:03 ` Harald Geyer
2018-03-12 16:10 ` [PATCH 3/5] arm64: dts: allwinner: a64: add simplefb for A64 SoC Harald Geyer
2018-03-13 8:27 ` Maxime Ripard
2018-03-13 9:18 ` Harald Geyer
2018-03-13 15:35 ` Maxime Ripard
2018-03-13 16:51 ` Harald Geyer
2018-03-14 8:01 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 4/5] arm64: dts: allwinner: a64: Add pwm device Harald Geyer
2018-03-13 8:29 ` Maxime Ripard
2018-03-12 16:10 ` [PATCH 5/5] arm64: allwinner: a64: Add support for TERES I laptop Harald Geyer
2018-03-13 8:41 ` Maxime Ripard
2018-03-13 11:07 ` Harald Geyer
2018-03-13 15:41 ` Maxime Ripard
2018-03-15 17:06 ` arm64: allwinner: " afzal mohammed
2018-03-16 6:28 ` afzal mohammed
2018-03-16 9:30 ` Harald Geyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313152744.fb2oo44v6lr4gyha@flea \
--to=maxime.ripard@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=harald@ccbib.org \
--cc=icenowy@aosc.io \
--cc=info@olimex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).