From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Thierry Escande <thierry.escande@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
David Brown <david.brown@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] Bluetooth: hci_qca: Add serdev support
Date: Tue, 13 Mar 2018 10:45:18 -0700 [thread overview]
Message-ID: <20180313174518.GU18510@minitux> (raw)
In-Reply-To: <20180313164444.19881-4-thierry.escande@linaro.org>
On Tue 13 Mar 09:44 PDT 2018, Thierry Escande wrote:
> @@ -50,6 +54,9 @@
> #define IBS_TX_IDLE_TIMEOUT_MS 2000
> #define BAUDRATE_SETTLE_TIMEOUT_MS 300
>
> +/* divclk4 rate */
The clock is called "susclk" in the BT chip, "divclk4" is the board
specific name for the clock source.
> +#define DIVCLK4_RATE_32KHZ 32768
> +
> /* HCI_IBS transmit side sleep protocol states */
> enum tx_ibs_states {
> HCI_IBS_TX_ASLEEP,
> @@ -111,6 +118,12 @@ struct qca_data {
> u64 votes_off;
> };
>
> +struct qca_serdev {
> + struct hci_uart serdev_hu;
> + struct gpio_desc *bt_en;
> + struct clk *divclk4;
Rename this to "susclk", or simply "clk".
> +};
Apart from this and Andy's comments this looks good.
Regards,
Bjorn
prev parent reply other threads:[~2018-03-13 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 16:44 [PATCH v2 0/3] Bluetooth: hci_qca: Add serdev support Thierry Escande
2018-03-13 16:44 ` [PATCH v2 1/3] arm64: dts: apq8096-db820c: enable bluetooth node Thierry Escande
2018-03-13 18:00 ` Bjorn Andersson
2018-03-13 16:44 ` [PATCH v2 2/3] dt-bindings: net: bluetooth: Add qualcomm-bluetooth Thierry Escande
2018-03-13 17:25 ` Bjorn Andersson
2018-03-13 16:44 ` [PATCH v2 3/3] Bluetooth: hci_qca: Add serdev support Thierry Escande
2018-03-13 16:50 ` Andy Shevchenko
2018-03-13 17:45 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313174518.GU18510@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).