From: Alexandru M Stan <amstan@chromium.org>
To: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Sean Paul <seanpaul@chromium.org>
Cc: devicetree@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
briannorris@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, dianders@chromium.org,
linux-rockchip@lists.infradead.org, marcheu@chromium.org,
hoegsberg@chromium.org,
Thierry Escande <thierry.escande@collabora.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Alexandru M Stan <amstan@chromium.org>,
Yakir Yang <kuankuan.y@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
zain wang <wzz@rock-chips.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH 0/2] Add backlight-pwm-passthru in analogix DP driver
Date: Thu, 15 Mar 2018 19:56:57 -0700 [thread overview]
Message-ID: <20180316025659.217423-1-amstan@chromium.org> (raw)
I noticed that the backlight on the ASUS Chromebook Flip C101 (bob) is
flickering.
We're sending it a high frequency pwm signal, but the EDP panel decided to
"parse" the signal, read the duty cycle, then make its own signal that
it sends to the LEDs.
So even though we send a nice high refresh rate at 1200Hz, the panel backlight
flickers at 200Hz (which is not even divisible by the 60Hz refresh rate).
The fix for that is to enable the EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU bit from
the DPCD EDP registers. This makes the panel actually follow the signal
we're giving it.
This series includes the optional dt binding to enable this fix
(backlight-pwm-passthru) and the corresponding code in the analogix
drm/bridge driver.
Alexandru M Stan (2):
dt-bindings: analogix-dp: Add backlight-pwm-passthru
drm/bridge: analogix: Enable EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU
.../bindings/display/bridge/analogix_dp.txt | 4 ++
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 48 ++++++++++++++++++++++
drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 +
3 files changed, 53 insertions(+)
--
2.13.5
next reply other threads:[~2018-03-16 2:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 2:56 Alexandru M Stan [this message]
2018-03-16 2:56 ` [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru Alexandru M Stan
2018-03-16 9:26 ` Archit Taneja
2018-03-18 12:52 ` Rob Herring
2018-03-20 14:07 ` Laurent Pinchart
2018-03-16 2:56 ` [PATCH 2/2] drm/bridge: analogix: Enable EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU Alexandru M Stan
2018-03-16 8:36 ` Daniel Vetter
2018-03-16 16:50 ` [PATCH 0/2] Add backlight-pwm-passthru in analogix DP driver Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316025659.217423-1-amstan@chromium.org \
--to=amstan@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=hoegsberg@chromium.org \
--cc=jeffy.chen@rock-chips.com \
--cc=kuankuan.y@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=marcheu@chromium.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=seanpaul@chromium.org \
--cc=thierry.escande@collabora.com \
--cc=wzz@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).