From: Rob Herring <robh@kernel.org>
To: Andreas Brauchli <a.brauchli@elementarea.net>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: chemical: sgp30: Support Sensirion SGPxx sensors
Date: Sun, 18 Mar 2018 07:48:33 -0500 [thread overview]
Message-ID: <20180317234938.qf7j45o53nu4ryu2@rob-hp-laptop> (raw)
In-Reply-To: <58a6dcdc4097d60e7bcee61ec1d0cbdf8ad3ae49.camel@elementarea.net>
On Sat, Mar 10, 2018 at 11:07:30PM +0100, Andreas Brauchli wrote:
> Support Sensirion SGP30 and SGPC3 multi-pixel I2C gas sensors
>
> Supported Features:
>
> * Indoor Air Quality (IAQ) concentrations for
> - tVOC (in_concentration_voc_input)
> - CO2eq (in_concentration_co2_input) - SGP30 only
> IAQ concentrations are periodically read out by a background thread
> to allow the sensor to maintain its internal baseline.
> * Baseline support for IAQ (in_iaq_baseline, set_iaq_baseline)
> * Gas concentration signals
> - Ethanol (in_concentration_ethanol_raw)
> - H2 (in_concentration_h2_raw) - SGP30 only
> * On-chip self test (in_selftest)
> * Sensor interface version (in_feature_set_version)
> * Sensor serial number (in_serial_id)
> * Humidity compensation
> With the help of an external humidity signal, the gas signals can be
> humidity-compensated. The sensor performs the compensation on-chip.
> * Power mode switching between low power mode (1/2Hz) and
> ultra low power mode (1/30Hz) sampling - SGPC3 only
> * Checksummed I2C communication
>
> For all features, refer to the data sheet or the documentation in
> Documentation/iio/chemical/sgp30.txt for more details.
>
> The ABI is documented in
> Documentation/ABI/testing/sysfs-bus-iio-chemical-sgp30
>
> Signed-off-by: Andreas Brauchli <andreas.brauchli@sensirion.com>
> ---
> .../ABI/testing/sysfs-bus-iio-chemical-sgp30 | 62 ++
> .../bindings/iio/chemical/sensirion,sgp30.txt | 15 +
Please split bindings to separate patch.
> Documentation/iio/chemical/sgp30.txt | 97 ++
> drivers/iio/chemical/Kconfig | 13 +
> drivers/iio/chemical/Makefile | 1 +
> drivers/iio/chemical/sgp30.c | 1120 ++++++++++++++++++++
> 6 files changed, 1308 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-chemical-sgp30
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,sgp30.txt
> create mode 100644 Documentation/iio/chemical/sgp30.txt
> create mode 100644 drivers/iio/chemical/sgp30.c
prev parent reply other threads:[~2018-03-18 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 22:07 [PATCH v2 2/2] iio: chemical: sgp30: Support Sensirion SGPxx sensors Andreas Brauchli
2018-03-11 11:42 ` Jonathan Cameron
2018-03-18 12:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317234938.qf7j45o53nu4ryu2@rob-hp-laptop \
--to=robh@kernel.org \
--cc=a.brauchli@elementarea.net \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).