From: Rob Herring <robh@kernel.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Tycho Andersen <tycho@tycho.ws>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] of: unittest: Remove VLA stack usage
Date: Sun, 18 Mar 2018 07:48:36 -0500 [thread overview]
Message-ID: <20180317235304.eohpmrii3htlmann@rob-hp-laptop> (raw)
In-Reply-To: <1520828843-22289-1-git-send-email-me@tobin.cc>
On Mon, Mar 12, 2018 at 03:27:23PM +1100, Tobin C. Harding wrote:
> The kernel would like to have all stack VLA usage removed[1]. This is a
> test function so the execution speed is not critical. We can allocate
> memory for this buffer instead of using a VLA. If kmalloc() fails just
> return.
>
> Allocate buffer with kmalloc().
>
> [1]: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
>
> Kees is this annoying you, CC'ing you an all my VLA patches?
>
> drivers/of/unittest.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
Applied.
Rob
prev parent reply other threads:[~2018-03-18 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 4:27 [PATCH] of: unittest: Remove VLA stack usage Tobin C. Harding
2018-03-18 12:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317235304.eohpmrii3htlmann@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox