Re: [PATCH 2/2] dt-bindings: usb: rt1711h device tree binding document

Re: [PATCH 2/2] dt-bindings: usb: rt1711h device tree binding document

[Guenter Roeck]

On Mon, Mar 19, 2018 at 11:49:35AM +0800, ShuFan Lee wrote:
> From: ShuFan Lee <shufan_lee@richtek.com>
> 
> Add device tree binding document for Richtek RT1711H Type-C chip driver

Cc: Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org
is missing. Added here but it might make sense to resend.

>
> Signed-off-by: ShuFan Lee <shufan_lee@richtek.com>
> ---
>  .../devicetree/bindings/usb/richtek,rt1711h.txt    | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
> 
>  changelogs between v2 & v3
>  - add dt-bindings document for rt1711h typec chip driver
> 
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt b/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
> new file mode 100644
> index 000000000000..7da4dac78ea7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
> @@ -0,0 +1,30 @@
> +Richtek RT1711H TypeC PD Controller.
> +
> +Required properties:
> + - compatible : Must be "richtek,rt1711h".
> + - reg : Must be 0x4e, it's slave address of RT1711H.
> +
> +Recommended properties :
> + - interrupt-parent : the phandle for the interrupt controller that
> +   provides interrupts for this device.
> + - interrupts : <a b> where a is the interrupt number and b represents an
> +   encoding of the sense and level information for the interrupt.
> +
> +Optional properties :
> + - rt,intr-gpios : IRQ GPIO pin that's connected to RT1711H interrupt.
> +   if interrupt-parent & interrupts are not defined, use this property instead.
> +
> +Example :
> +rt1711h@4e {
> +	compatible = "richtek,rt1711h";
> +	reg = <0x4e>;
> +	interrupt-parent = <&gpio26>;
> +	interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +};
> +
> +Example using rt,intr-gpios :
> +rt1711h@4e {
> +	compatible = "richtek,rt1711h";
> +	reg = <0x4e>;
> +	rt,intr-gpios = <&gpio26 0 0x0>;
> +};
> -- 
> 1.9.1
> 

Re: [PATCH 2/2] dt-bindings: usb: rt1711h device tree binding document

[李書帆]

Hi Guenter,

2018-03-20 0:29 GMT+08:00 Guenter Roeck <linux@roeck-us.net>:
> On Mon, Mar 19, 2018 at 11:49:35AM +0800, ShuFan Lee wrote:
>> From: ShuFan Lee <shufan_lee@richtek.com>
>>
>> Add device tree binding document for Richtek RT1711H Type-C chip driver
>
> Cc: Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org
> is missing. Added here but it might make sense to resend.
Thank you for reminding, I'll resend it.

>
>>
>> Signed-off-by: ShuFan Lee <shufan_lee@richtek.com>
>> ---
>>  .../devicetree/bindings/usb/richtek,rt1711h.txt    | 30 ++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
>>
>>  changelogs between v2 & v3
>>  - add dt-bindings document for rt1711h typec chip driver
>>
>> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt b/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
>> new file mode 100644
>> index 000000000000..7da4dac78ea7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.txt
>> @@ -0,0 +1,30 @@
>> +Richtek RT1711H TypeC PD Controller.
>> +
>> +Required properties:
>> + - compatible : Must be "richtek,rt1711h".
>> + - reg : Must be 0x4e, it's slave address of RT1711H.
>> +
>> +Recommended properties :
>> + - interrupt-parent : the phandle for the interrupt controller that
>> +   provides interrupts for this device.
>> + - interrupts : <a b> where a is the interrupt number and b represents an
>> +   encoding of the sense and level information for the interrupt.
>> +
>> +Optional properties :
>> + - rt,intr-gpios : IRQ GPIO pin that's connected to RT1711H interrupt.
>> +   if interrupt-parent & interrupts are not defined, use this property instead.
>> +
>> +Example :
>> +rt1711h@4e {
>> +     compatible = "richtek,rt1711h";
>> +     reg = <0x4e>;
>> +     interrupt-parent = <&gpio26>;
>> +     interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
>> +};
>> +
>> +Example using rt,intr-gpios :
>> +rt1711h@4e {
>> +     compatible = "richtek,rt1711h";
>> +     reg = <0x4e>;
>> +     rt,intr-gpios = <&gpio26 0 0x0>;
>> +};
>> --
>> 1.9.1
>>



-- 
Best Regards,
書帆