From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Harald Geyer <harald@ccbib.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <icenowy@aosc.io>,
info@olimex.com
Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop
Date: Thu, 22 Mar 2018 18:59:04 +0100 [thread overview]
Message-ID: <20180322175904.j2aho4tglifezzhq@flea> (raw)
In-Reply-To: <0288a32a-bbbf-20ca-2ebf-6fc8e82168df@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]
On Tue, Mar 20, 2018 at 05:09:47PM +0000, Andre Przywara wrote:
> Hi,
>
> On 20/03/18 14:13, Maxime Ripard wrote:
> > On Mon, Mar 19, 2018 at 04:27:36PM +0100, Harald Geyer wrote:
> >>> together with all the patches but the
> >>> PWM (so I had to drop the backlight node as well).
> >>>
> >>> Please coordinate with Andre about who should send the PWM support.
> >>
> >> Seems the patch got broken because only the backlight node but not the
> >> pwm node was removed. Anyway, since Andre has already sent an updated
> >> version of his series, maybe just revert the broken patch, merge his
> >> series and then apply the original teres-i patch again?
> >
> > Unfortunately, there's dependencies on the PWM driver itself, and the
> > maintainer hasn't replied yet.
>
> But those dependencies are purely "administrative", not technical,
> aren't they? As the existing driver worked already with the DT changes,
> it's just the listing of the compatible strings in the binding doc that
> is missing? IIRC we added those later on in the past already.
>
> So I think it's safe to merge them independently:
> "[PATCH v2 1/4] pwm: sun4i: drop unused .has_rdy member" and
> "[PATCH v2 2/4] pwm: sun4i: simplify controller mapping" are
> PWM fixes and go via Thierry, I guess.
>
> "[PATCH v2 3/4] dt-bindings: pwm: sunxi: add new compatible strings" is
> just Documentation of existing behaviour, and independent from 1/4 and 2/4.
>
> "[PATCH v2 4/4] dts: sunxi: A64: Add PWM controllers" just "softly"
> depends on the introduction of the compatible strings in 3/4, but has no
> real technical dependency. It can go in any time on its own without
> breaking the build or functionality.
>
> Or am I too sloppy here?
As far as I know, Thierry never commented on any version of these
patches, so I'd still like to get his review first.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-22 17:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 16:25 [PATCHv2 0/5] arm64: allwinner: Add support for TERES-I laptop Harald Geyer
2018-03-15 16:25 ` [PATCHv2 1/5] arm64: dts: allwinner: a64: Add i2c0 pins Harald Geyer
2018-03-15 16:25 ` [PATCHv2 2/5] arm64: dts: allwinner: a64: Add watchdog Harald Geyer
2018-03-18 12:52 ` Rob Herring
2018-03-15 16:25 ` [PATCHv2 3/5] arm64: dts: allwinner: a64: add simplefb for A64 SoC Harald Geyer
2018-03-15 16:25 ` [PATCHv2 4/5] arm64: dts: allwinner: a64: Add pwm device Harald Geyer
2018-03-18 12:52 ` Rob Herring
2018-03-18 13:51 ` André Przywara
2018-03-15 16:25 ` [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop Harald Geyer
2018-03-16 6:37 ` afzal mohammed
2018-03-16 17:50 ` afzal mohammed
2018-03-18 20:22 ` Maxime Ripard
2018-03-19 7:17 ` afzal mohammed
2018-03-19 21:27 ` Maxime Ripard
2018-03-19 15:27 ` Harald Geyer
2018-03-20 14:13 ` Maxime Ripard
2018-03-20 17:09 ` Andre Przywara
2018-03-22 17:59 ` Maxime Ripard [this message]
2018-06-22 16:27 ` Icenowy Zheng
2018-06-24 16:34 ` Harald Geyer
2018-06-25 7:43 ` Arend van Spriel
2018-06-25 7:47 ` Icenowy Zheng
2018-06-25 8:13 ` Arend van Spriel
2018-06-25 10:42 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322175904.j2aho4tglifezzhq@flea \
--to=maxime.ripard@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=harald@ccbib.org \
--cc=icenowy@aosc.io \
--cc=info@olimex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).