From: Lina Iyer <ilina@codeaurora.org>
To: David Collins <collinsd@codeaurora.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
broonie@kernel.org, lgirdwood@gmail.com, mark.rutland@arm.com,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, rnayak@codeaurora.org
Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver
Date: Mon, 26 Mar 2018 09:35:20 -0600 [thread overview]
Message-ID: <20180326153520.GC22084@codeaurora.org> (raw)
In-Reply-To: <493c1f5d-df99-ca68-0f90-a7937a696f5d@codeaurora.org>
On Thu, Mar 22 2018 at 19:30 -0600, David Collins wrote:
>Hello Stephen,
>
>Thank you for the very detailed review feedback.
>
>On 03/21/2018 12:07 PM, Stephen Boyd wrote:
>> Quoting David Collins (2018-03-16 18:09:10)
>>> +static int rpmh_regulator_remove(struct platform_device *pdev)
>>> +{
>>> + struct rpmh_pmic *pmic = platform_get_drvdata(pdev);
>>> +
>>> + rpmh_release(pmic->rpmh_client);
>>
>> I'm still lost on what rpmh_client is giving us besides more code we
>> don't need. I'll ping the rpmh thread again.
>
>Let's see if Lina is willing to add some devm_* calls so that no cleanup
>is required.
>
I will look into this.
-- Lina
next prev parent reply other threads:[~2018-03-26 15:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 1:09 [PATCH 0/2] regulator: add QCOM RPMh regulator driver David Collins
2018-03-17 1:09 ` [PATCH 1/2] " David Collins
2018-03-18 20:38 ` kbuild test robot
2018-03-18 20:38 ` [PATCH] regulator: fix platform_no_drv_owner.cocci warnings kbuild test robot
2018-03-19 21:47 ` David Collins
2018-03-21 2:16 ` [PATCH 1/2] regulator: add QCOM RPMh regulator driver Doug Anderson
2018-03-22 22:31 ` David Collins
2018-03-23 20:00 ` Doug Anderson
2018-03-27 11:56 ` Mark Brown
2018-03-27 20:51 ` Doug Anderson
2018-03-28 2:28 ` Mark Brown
2018-03-27 23:38 ` David Collins
2018-03-28 2:08 ` Mark Brown
2018-03-27 23:22 ` David Collins
2018-03-21 19:07 ` Stephen Boyd
2018-03-23 1:30 ` David Collins
2018-03-26 15:35 ` Lina Iyer [this message]
2018-04-19 5:55 ` Stephen Boyd
2018-04-19 12:08 ` Mark Brown
2018-04-20 19:28 ` David Collins
2018-04-24 17:41 ` Mark Brown
2018-04-24 20:46 ` David Collins
2018-05-17 6:09 ` Mark Brown
2018-05-17 20:48 ` David Collins
2018-05-22 16:36 ` Mark Brown
2018-04-20 19:07 ` David Collins
2018-04-20 22:44 ` Lina Iyer
2018-04-24 20:33 ` David Collins
2018-03-29 22:36 ` Doug Anderson
2018-03-17 1:09 ` [PATCH 2/2] dt-bindings: regulator: add QCOM RPMh regulator bindings David Collins
2018-03-21 2:16 ` Doug Anderson
2018-03-21 23:54 ` David Collins
2018-03-21 2:43 ` Mark Brown
2018-03-27 23:48 ` David Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326153520.GC22084@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).