From: Andrew Lunn <andrew@lunn.ch>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
malat@debian.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, w-kwok2@ti.com, robh+dt@kernel.org,
ssantosh@kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [net-next PATCH 3/5] net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC
Date: Mon, 26 Mar 2018 22:28:42 +0200 [thread overview]
Message-ID: <20180326202842.GB5862@lunn.ch> (raw)
In-Reply-To: <1522095312-23249-4-git-send-email-m-karicheri2@ti.com>
On Mon, Mar 26, 2018 at 04:15:10PM -0400, Murali Karicheri wrote:
> K2G SoC uses 2u cpsw h/w. It uses RGMII instead of SGMII to interface with
> Phy. This patch enhances the driver to check RGMII status instead of SGMII
> status for link state determination. Also map all of the vlan priorities
> to zero as the packet DMA is enabled to receive only flow id 0 which maps
> to priority zero.
>
> Additionally, When a phy with rgmii interface requires internal delay, the
> same is set in the phy driver. To support such phy devices, add a phy-mode
> handling code in the driver using of_get_phy_mode() and pass the obtained
> phy mode to of_phy_connect()
Hi Murali
Please break this patch up. One patch should do one thing. That makes
it easy to review. There are too many things going on at once here.
Andrew
next prev parent reply other threads:[~2018-03-26 20:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 20:15 [net-next PATCH 0/5] Add support for netcp driver on K2G SoC Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 1/5] soc: ti: K2G: enhancement to support QMSS in NSS Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 2/5] soc: ti: K2G: provide APIs to support driver probe deferral Murali Karicheri
2018-03-26 20:48 ` Andrew Lunn
2018-03-27 13:32 ` Murali Karicheri
2018-03-27 14:03 ` Andrew Lunn
2018-03-27 14:31 ` Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 3/5] net: netcp: ethss enhancements to support 2u cpsw h/w on K2G SoC Murali Karicheri
2018-03-26 20:28 ` Andrew Lunn [this message]
2018-03-27 13:23 ` Murali Karicheri
2018-03-27 13:47 ` Andrew Lunn
2018-03-26 20:15 ` [net-next PATCH 4/5] Revert "net: netcp: remove dead code from the driver" Murali Karicheri
2018-03-26 20:15 ` [net-next PATCH 5/5] net: netcp: support probe deferral Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326202842.GB5862@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).