From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com
Subject: Re: [PATCH v2 1/2] Revert "arm64: dts: fsl: fix ifc simple-bus unit address format warnings"
Date: Tue, 27 Mar 2018 16:01:47 +0800 [thread overview]
Message-ID: <20180327080145.GF8857@dragon> (raw)
In-Reply-To: <1522081243-30871-1-git-send-email-festevam@gmail.com>
On Mon, Mar 26, 2018 at 01:20:42PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> This reverts commit f81d7af7957539b7808961f929f945381530acb9.
>
> As explained by Rob Herring:
>
> "This "fix" is wrong. Memory controllers with chip selects should have
> the chip select in the unit-address. The correct fix here is you should
> drop "simple-bus"."
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied both, thanks.
prev parent reply other threads:[~2018-03-27 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 16:20 [PATCH v2 1/2] Revert "arm64: dts: fsl: fix ifc simple-bus unit address format warnings" Fabio Estevam
2018-03-26 16:20 ` [PATCH v2 2/2] Revert "dt-bindings: ifc: Fix the unit address format in the examples" Fabio Estevam
2018-03-27 8:01 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327080145.GF8857@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).