devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Boris Brezillon" <boris.brezillon@free-electrons.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	devicetree@vger.kernel.org, "Richard Weinberger" <richard@nod.at>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"John Crispin" <john@phrozen.org>,
	"Frank Rowand" <frowand.list@gmail.com>,
	"Marek Vasut" <marek.vasut@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	"Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Peter Rosin" <peda@axentia.se>
Subject: Re: [PATCH V10 0/3] mtd: read partitions compatible prop for "ofpart" type
Date: Tue, 27 Mar 2018 11:41:30 +0200	[thread overview]
Message-ID: <20180327114130.0fa3ee0e@bbrezillon> (raw)
In-Reply-To: <20180314121044.12033-1-zajec5@gmail.com>

On Wed, 14 Mar 2018 13:10:41 +0100
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This patchset provides a proper support for flash device DT node with
> "partitions" subnode using "compatible" property. It's already
> documented in the: Documentation/devicetree/bindings/mtd/partition.txt
> 
> We believed that version 7 was ready to go, but soon after landing in
> the linux-next we got a regression report from Peter. Later versions
> takes a safe path by:
> 1) Respecting parsers order as specified in the default/driver-provided
>    list.
> 2) Looking at "compatible" property only when "ofpart" type gets
>    speciied.
> 
> Version 9 was successfully tested by Peter and version 10 just squashes
> two commits into a one.
> 
> I double-checked the code and cannot think of any regression this could
> cause. I also hope this design (roughly discussed with Boris) can be
> acceptable for the mtd subsystem.
> 
> The most important patch from this patchset (1/3) was reviewed by Rob in
> the
> [PATCH V6 1/2] mtd: partitions: add of_match_table parser matching
> https://patchwork.ozlabs.org/comment/1831551/
> 
> If possible this is a 4.17 material.

Applied, finally. I'm still convinced putting this information in the
"partitions" node compatible is a bad idea because it adds extra
complexity to something that was already quite complex, but you won!

Note that Rob had comments on [1] that you never answered, so I'm not
even sure when we'll start seeing boards using this infrastructure.

[1]http://patchwork.ozlabs.org/patch/859690/

-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      parent reply	other threads:[~2018-03-27  9:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 20:10 [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type Rafał Miłecki
     [not found] ` <20180130201059.4424-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-30 20:10   ` [PATCH V9 1/4] mtd: partitions: add special treating for the "ofpart" parser type Rafał Miłecki
2018-01-30 20:10   ` [PATCH V9 2/4] mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better Rafał Miłecki
2018-01-30 20:10   ` [PATCH V9 3/4] mtd: partitions: add of_match_table parser matching Rafał Miłecki
2018-01-30 20:10   ` [PATCH V9 4/4] mtd: ofpart: add of_match_table with "fixed-partitions" Rafał Miłecki
2018-02-01 14:32   ` [PATCH V9 0/4] mtd: read partitions compatible prop for "ofpart" type Peter Rosin
2018-03-11 22:35 ` Richard Weinberger
2018-03-14 12:10 ` [PATCH V10 0/3] " Rafał Miłecki
2018-03-14 12:10   ` [PATCH V10 1/3] mtd: partitions: add of_match_table parser matching for the " Rafał Miłecki
2018-03-14 12:10   ` [PATCH V10 2/3] mtd: rename "ofpart" parser to "fixed-partitions" as it fits it better Rafał Miłecki
2018-03-14 12:10   ` [PATCH V10 3/3] mtd: ofpart: add of_match_table with "fixed-partitions" Rafał Miłecki
2018-03-26 11:30   ` [PATCH V10 0/3] mtd: read partitions compatible prop for "ofpart" type Richard Weinberger
2018-03-27  9:41   ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327114130.0fa3ee0e@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=john@phrozen.org \
    --cc=jonas.gorski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).