From: Andrew Lunn <andrew@lunn.ch>
To: "Vicenţiu Galanopulo" <vicentiu.galanopulo@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"marcel@holtmann.org" <marcel@holtmann.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>
Subject: Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up
Date: Tue, 27 Mar 2018 16:24:08 +0200 [thread overview]
Message-ID: <20180327142408.GL5862@lunn.ch> (raw)
In-Reply-To: <HE1PR0402MB3578B3D33160EBE59C2FD7D7EEAC0@HE1PR0402MB3578.eurprd04.prod.outlook.com>
> > This is a 2nd MDIO address, right? Can't you just append this to reg property?
Hi Rob
It is a sub address.
There are two different MDIO addressing schemes. Clause 22 allowed for
32 different addresses on an MDIO bus. Clause 45 extended that. You
have the existing 32 addresses for a package. However, within a
package, you can have 32 devices.
You are supposed to be able to look are registers inside the package,
and it will tell you which devices in the packages are in use. You can
then look at those devices and figure out what they are using ID
registers.
However some vendors get this wrong, they don't fill in the devices in
package information. So the generic probe code never finds them. We
need to pass it a hint, go looking at this specific device in the
package.
You can mix Clause 22 and Clause 45 on the same bus. Does DT allow two
different reg formats to be used at once? Can we have some reg
properties with a single value, and some with two values? I thought
#address-cells = <1> means there should be a single address in reg.
Andrew
next prev parent reply other threads:[~2018-03-27 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 15:05 [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up Vicentiu Galanopulo
2018-03-23 15:44 ` Andrew Lunn
2018-03-26 22:25 ` Rob Herring
2018-03-27 8:10 ` Vicenţiu Galanopulo
2018-03-27 14:24 ` Andrew Lunn [this message]
2018-03-28 14:31 ` Rob Herring
2018-03-28 15:27 ` Andrew Lunn
2018-03-26 22:44 ` Florian Fainelli
2018-03-27 10:02 ` Vicenţiu Galanopulo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327142408.GL5862@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.marginean@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vicentiu.galanopulo@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).