From: David Gibson <david@gibson.dropbear.id.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Jon Loeliger <jdl@jdl.com>,
devicetree-compiler@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH dtc] checks: Print duplicate node name instead of parent name
Date: Wed, 28 Mar 2018 10:13:30 +1100 [thread overview]
Message-ID: <20180327231330.GA3510@umbus.fritz.box> (raw)
In-Reply-To: <1522152811-28022-1-git-send-email-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Tue, Mar 27, 2018 at 02:13:31PM +0200, Geert Uytterhoeven wrote:
> When refactoring node path printing, the code checking for duplicate
> node names was accidentally changed to print the name of the parent
> node, instead of the name of the duplicated child node.
>
> Fixes: 88960e3989073207 ("checks: centralize printing of node path in check_msg")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thanks.
> ---
> Also applies to Linux' scripts/dtc/checks.c.
> ---
> checks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/checks.c b/checks.c
> index 1e6a88c81a998415..e6a38a87cc7d9aac 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -255,7 +255,7 @@ static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
> child2;
> child2 = child2->next_sibling)
> if (streq(child->name, child2->name))
> - FAIL(c, dti, node, "Duplicate node name");
> + FAIL(c, dti, child2, "Duplicate node name");
> }
> ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-03-27 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 12:13 [PATCH dtc] checks: Print duplicate node name instead of parent name Geert Uytterhoeven
2018-03-27 23:13 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327231330.GA3510@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jdl@jdl.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).