[PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

[PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

[Prabhakar Kushwaha]

Connection between flash and controller is not necessary to be always
of same type. It may varies from platform to platform.

Adding endianness (optional) property to provide connection type
information.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes for v2: updated subject
Changes for v3: fixed typo for "big-endian"
Changes for v4: Moved binding definition in mtd-physmap.txt
as discussed at https://patchwork.ozlabs.org/patch/842543/
Changes for v5: Sending as it is
Changes for v6: Updated binding when endianness property is absent
Changes for v7: Updated binding details

 Documentation/devicetree/bindings/mtd/mtd-physmap.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt
index 4a0a48bf4ecb..232fa12e90ef 100644
--- a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt
+++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt
@@ -41,6 +41,13 @@ additional (optional) property is defined:
 
  - erase-size : The chip's physical erase block size in bytes.
 
+ The device tree may optionally contain endianness property.
+ little-endian or big-endian : It Represents the endianness that should be used
+                               by the controller to  properly read/write data
+			       from/to the flash. If this property is missing,
+			       the endianness is chosen by the system
+			       (potentially based on extra configuration options).
+
 The device tree may optionally contain sub-nodes describing partitions of the
 address space. See partition.txt for more detail.
 
-- 
2.14.1

Re: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

[Boris Brezillon]

On Wed, 28 Mar 2018 11:14:43 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:

> Connection between flash and controller is not necessary to be always
> of same type. It may varies from platform to platform.
> 
> Adding endianness (optional) property to provide connection type
> information.

You forgot to adjust your commit message.

If you're okay, I'll replace your message by:

"
Provides a way to specify the endianness to use when accessing a
memory-mapped flash.
"

> 
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Changes for v2: updated subject
> Changes for v3: fixed typo for "big-endian"
> Changes for v4: Moved binding definition in mtd-physmap.txt
> as discussed at https://patchwork.ozlabs.org/patch/842543/
> Changes for v5: Sending as it is
> Changes for v6: Updated binding when endianness property is absent
> Changes for v7: Updated binding details
> 
>  Documentation/devicetree/bindings/mtd/mtd-physmap.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt
> index 4a0a48bf4ecb..232fa12e90ef 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd-physmap.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtd-physmap.txt
> @@ -41,6 +41,13 @@ additional (optional) property is defined:
>  
>   - erase-size : The chip's physical erase block size in bytes.
>  
> + The device tree may optionally contain endianness property.
> + little-endian or big-endian : It Represents the endianness that should be used
> +                               by the controller to  properly read/write data
> +			       from/to the flash. If this property is missing,
> +			       the endianness is chosen by the system
> +			       (potentially based on extra configuration options).
> +
>  The device tree may optionally contain sub-nodes describing partitions of the
>  address space. See partition.txt for more detail.
>  



-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

RE: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

[Prabhakar Kushwaha]

Hi Boris,

> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> Sent: Wednesday, March 28, 2018 2:00 PM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: linux-mtd@lists.infradead.org; devicetree@vger.kernel.org;
> mark.rutland@arm.com; robh@kernel.org; boris.brezillon@free-electrons.com;
> Poonam Aggrwal <poonam.aggrwal@nxp.com>; Leo Li <leoyang.li@nxp.com>;
> oss@buserror.net; computersforpeace@gmail.com; shawnguo@kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness
> supports
> 
> On Wed, 28 Mar 2018 11:14:43 +0530
> Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> 
> > Connection between flash and controller is not necessary to be always
> > of same type. It may varies from platform to platform.
> >
> > Adding endianness (optional) property to provide connection type
> > information.
> 
> You forgot to adjust your commit message.
> 
> If you're okay, I'll replace your message by:
> 
> "
> Provides a way to specify the endianness to use when accessing a memory-
> mapped flash.
> "
> 

Thanks for catching this. Please adjust as you suggested.

--prabhakar

Re: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness supports

[Boris Brezillon]

On Wed, 28 Mar 2018 09:48:08 +0000
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:

> Hi Boris,
> 
> > -----Original Message-----
> > From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> > Sent: Wednesday, March 28, 2018 2:00 PM
> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Cc: linux-mtd@lists.infradead.org; devicetree@vger.kernel.org;
> > mark.rutland@arm.com; robh@kernel.org; boris.brezillon@free-electrons.com;
> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Leo Li <leoyang.li@nxp.com>;
> > oss@buserror.net; computersforpeace@gmail.com; shawnguo@kernel.org;
> > linux-arm-kernel@lists.infradead.org
> > Subject: Re: [PATCH 1/2][v7] dt-bindings: mtd-physmap: Add endianness
> > supports
> > 
> > On Wed, 28 Mar 2018 11:14:43 +0530
> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> >   
> > > Connection between flash and controller is not necessary to be always
> > > of same type. It may varies from platform to platform.
> > >
> > > Adding endianness (optional) property to provide connection type
> > > information.  
> > 
> > You forgot to adjust your commit message.
> > 
> > If you're okay, I'll replace your message by:
> > 
> > "
> > Provides a way to specify the endianness to use when accessing a memory-
> > mapped flash.
> > "
> >   
> 
> Thanks for catching this. Please adjust as you suggested.

Applied.

Thanks,

Boris

> 
> --prabhakar
> 
> 



-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com