public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	Mark Rutland <mark.rutland@arm.com>,
	Miroslav Lichvar <mlichvar@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core.
Date: Mon, 2 Apr 2018 20:55:27 -0700	[thread overview]
Message-ID: <20180403035527.lgcm6gql3qx4rpuv@localhost> (raw)
In-Reply-To: <4c3c939f-4cbe-51db-c141-950b85a5b4de@gmail.com>

On Sun, Mar 25, 2018 at 04:01:49PM -0700, Florian Fainelli wrote:
> The best that I can think about and it still is a hack in some way, is
> to you have your time stamping driver create a proxy mii_bus whose
> purpose is just to hook to mdio/phy_device events (such as link changes)
> in order to do what is necessary, or at least, this would indicate its
> transparent nature towards the MDIO/MDC lines...

That won't work at all, AFAICT.  There is only one mii_bus per netdev,
that is one that is attached to the phydev.
 
> Tangential: the existing PHY time stamping logic should probably be
> generalized to a mdio_device (which the phy_device is a specialized
> superset of) instead of to the phy_device. This would still allow
> existing use cases but it would also allow us to support possible "pure
> MDIO" devices would that become some thing in the future.

So this is exactly what I did.  The time stamping methods were pushed
down into the mdio_device.  The active device (mdiots pointer) points
either to a non-PHY mdio_device or to the mdio_device embedded in the
phydev.

Thanks,
Richard

  reply	other threads:[~2018-04-03  3:55 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 18:58 [PATCH net-next RFC V1 0/5] Peer to Peer One-Step time stamping Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 1/5] net: Introduce peer to peer one step PTP " Richard Cochran
2018-03-21 20:05   ` Keller, Jacob E
2018-03-21 21:26     ` Richard Cochran
2018-03-21 23:51       ` Keller, Jacob E
2018-03-21 18:58 ` [PATCH net-next RFC V1 2/5] net: phy: Move time stamping interface into the generic mdio layer Richard Cochran
2018-03-21 19:10   ` Florian Fainelli
2018-03-21 21:45     ` Richard Cochran
2018-03-24 16:59       ` Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 3/5] net: Introduce field for the MII time stamper Richard Cochran
2018-03-21 19:12   ` Florian Fainelli
2018-03-21 21:51     ` Richard Cochran
2018-03-24 17:01     ` Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 4/5] net: Use the generic MII time stamper when available Richard Cochran
2018-03-21 18:58 ` [PATCH net-next RFC V1 5/5] net: mdio: Add a driver for InES time stamping IP core Richard Cochran
2018-03-21 19:33   ` Andrew Lunn
2018-03-21 21:36     ` Richard Cochran
2018-03-21 21:44       ` Andrew Lunn
2018-03-21 21:57         ` Richard Cochran
2018-03-21 22:16           ` Andrew Lunn
2018-03-21 22:47             ` Richard Cochran
2018-03-21 23:50               ` Andrew Lunn
2018-03-24 17:12                 ` Richard Cochran
2018-03-24 18:48                   ` Andrew Lunn
2018-03-25  4:51                     ` Richard Cochran
2018-03-25 15:59                       ` Andrew Lunn
2018-03-25 22:10                         ` Richard Cochran
2018-03-25 23:01                           ` Florian Fainelli
2018-04-03  3:55                             ` Richard Cochran [this message]
2018-04-03 13:13                               ` Andrew Lunn
2018-04-03 15:02                                 ` Richard Cochran
2018-03-25 23:01                           ` Andrew Lunn
2018-04-03  4:27                             ` Richard Cochran
2018-03-25 23:06                           ` Andrew Lunn
2018-03-25 22:14                         ` Richard Cochran
2018-03-22  0:43               ` Andrew Lunn
2018-03-22  1:57                 ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180403035527.lgcm6gql3qx4rpuv@localhost \
    --to=richardcochran@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mlichvar@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox