From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?TXlsw6huZQ==?= Josserand Subject: Re: [PATCH v5 01/13] ARM: move cputype definitions into another file Date: Tue, 3 Apr 2018 09:27:24 +0200 Message-ID: <20180403092724.607e8e37@dell-desktop.home> References: <20180403061836.3926-1-mylene.josserand@bootlin.com> <20180403061836.3926-2-mylene.josserand@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chen-Yu Tsai Cc: Russell King , Maxime Ripard , Marc Zyngier , Mark Rutland , Rob Herring , devicetree , LABBE Corentin , quentin.schulz@bootlin.com, Thomas Petazzoni , linux-arm-kernel , linux-kernel List-Id: devicetree@vger.kernel.org Hi Chen-Yu, Thank you for your review! On Tue, 3 Apr 2018 14:52:45 +0800 Chen-Yu Tsai wrote: > On Tue, Apr 3, 2018 at 2:18 PM, Mylène Josserand > wrote: > > To add the support for SMP on sun8i-a83t, we will use some > > definitions in an assembly file so move definitions into > > another file to separate C functions and macro defintions. > > Instead of moving the definitions, you could guard all the C > stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that. Oh, right. It is better with this check so I will use that in the next iteration of my series. Best regards, Mylène -- Mylène Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com > > ChenYu > > > Signed-off-by: Mylène Josserand > > --- > > arch/arm/include/asm/cputype.h | 94 +----------------------------------- > > arch/arm/include/asm/cputype_def.h | 98 ++++++++++++++++++++++++++++++++++++++