From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Richard Sproul <sproul@cadence.com>,
Alan Douglas <adouglas@cadence.com>,
Steve Creaney <screaney@cadence.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Benoit Parrot <bparrot@ti.com>,
nm@ti.com, Simon Hatliff <hatliff@cadence.com>
Subject: Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver
Date: Tue, 3 Apr 2018 16:25:13 +0200 [thread overview]
Message-ID: <20180403142513.435jdbs7u7nathtm@flea> (raw)
In-Reply-To: <20180329133255.GD26532@bigcity.dyn.berto.se>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
Hi Niklas,
Thanks for your review,
On Thu, Mar 29, 2018 at 03:32:55PM +0200, Niklas Söderlund wrote:
> > diff --git a/drivers/media/platform/cadence/Kconfig b/drivers/media/platform/cadence/Kconfig
> > new file mode 100644
> > index 000000000000..18f061e5cbd1
> > --- /dev/null
> > +++ b/drivers/media/platform/cadence/Kconfig
> > @@ -0,0 +1,17 @@
> > +config VIDEO_CADENCE
> > + bool "Cadence Video Devices"
>
> I'm no expert on Kconfig best practices so if nothing else I might learn
> something. There is no need to add a description to this option as it
> only groups the Cadence drivers?
You don't strictly need it, but you're right and one should be better,
I've added it.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-03 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 13:33 [PATCH v8 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 RX Maxime Ripard
[not found] ` <20180215133335.9335-1-maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
2018-02-15 13:33 ` [PATCH v8 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings Maxime Ripard
2018-03-29 13:06 ` Niklas Söderlund
2018-02-15 13:33 ` [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver Maxime Ripard
2018-03-01 20:09 ` Benoit Parrot
2018-03-02 9:35 ` Maxime Ripard
2018-03-29 13:32 ` Niklas Söderlund
2018-04-03 14:25 ` Maxime Ripard [this message]
2018-03-09 15:36 ` [PATCH v8 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 RX Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403142513.435jdbs7u7nathtm@flea \
--to=maxime.ripard@bootlin.com \
--cc=adouglas@cadence.com \
--cc=boris.brezillon@bootlin.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=hatliff@cadence.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=screaney@cadence.com \
--cc=sproul@cadence.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).