From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manivannan Sadhasivam Subject: Re: [PATCH v6 3/9] pinctrl: actions: Add Actions S900 pinctrl driver Date: Tue, 3 Apr 2018 22:44:01 +0530 Message-ID: <20180403171401.etcvqe4xrkcl7sbh@linaro.org> References: <20180328174703.19778-1-manivannan.sadhasivam@linaro.org> <20180328174703.19778-4-manivannan.sadhasivam@linaro.org> <20180403170016.w3scjt57ssvk6zyi@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Andy Shevchenko , Linus Walleij , Rob Herring , =?utf-8?B?5YiY54Kc?= , mp-cs@actions-semi.com, 96boards@ucrobotics.com, devicetree , Daniel Thompson , amit.kucheria@linaro.org, linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , hzhang@ucrobotics.com, bdong@ucrobotics.com, Mani Sadhasivam List-Id: devicetree@vger.kernel.org On Tue, Apr 03, 2018 at 07:03:46PM +0200, Andreas Färber wrote: > Hi Mani, > > Am 03.04.2018 um 19:00 schrieb Manivannan Sadhasivam: > > On Sat, Mar 31, 2018 at 12:16:49AM +0300, Andy Shevchenko wrote: > >> On Wed, Mar 28, 2018 at 8:46 PM, Manivannan Sadhasivam > >> wrote: > >>> +static const struct pinconf_ops owl_pinconf_ops = { > >>> + .is_generic = true, > >>> + .pin_config_get = owl_pin_config_get, > >>> + .pin_config_set = owl_pin_config_set, > >>> + .pin_config_group_get = owl_group_config_get, > >>> + .pin_config_group_set = owl_group_config_set > >> > >> It's still good idea to leave comma here... > >> > > > > I'm confused. What is the criteria for removing/keeping comma for last member > > of struct? I followed your gpio driver suggestion. > > No comma for list terminator ("{}") because nothing goes after it; comma > whenever it allows adding a new line without touching the old one, i.e. > keeping future diff small. > Thanks for the clarification Andreas! Keeping the future diff small is the key, understood. Thanks, Mani > Cheers, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg)