* [PATCH] ARM: dts: ls1021a: Specify TBIPA register address [not found] <20180406123836.12019-2-esben.haabendal@gmail.com> @ 2018-04-06 12:46 ` Esben Haabendal 2018-04-08 16:45 ` David Miller 0 siblings, 1 reply; 2+ messages in thread From: Esben Haabendal @ 2018-04-06 12:46 UTC (permalink / raw) To: netdev Cc: Rob Herring, Mark Rutland, devicetree, linux-kernel, Claudiu Manoil, David S . Miller, Gustavo A . R . Silva, Esben Haabendal From: Esben Haabendal <eha@deif.com> The current (mildly evil) fsl_pq_mdio code uses an undocumented shadow of the TBIPA register on LS1021A, which happens to be read-only. Changing TBI PHY address therefore does not work on LS1021A. The real (and documented) address of the TBIPA registere lies in the eTSEC block and not in MDIO/MII, which is read/write, so using that fixes the problem. Signed-off-by: Esben Haabendal <eha@deif.com> --- arch/arm/boot/dts/ls1021a.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index c31dad98f989..728e206009ea 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -587,7 +587,8 @@ device_type = "mdio"; #address-cells = <1>; #size-cells = <0>; - reg = <0x0 0x2d24000 0x0 0x4000>; + reg = <0x0 0x2d24000 0x0 0x4000>, + <0x0 0x2d10030 0x0 0x4>; }; ptp_clock@2d10e00 { -- 2.16.3 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: ls1021a: Specify TBIPA register address 2018-04-06 12:46 ` [PATCH] ARM: dts: ls1021a: Specify TBIPA register address Esben Haabendal @ 2018-04-08 16:45 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2018-04-08 16:45 UTC (permalink / raw) To: esben.haabendal Cc: netdev, robh+dt, mark.rutland, devicetree, linux-kernel, claudiu.manoil, garsilva, eha From: Esben Haabendal <esben.haabendal@gmail.com> Date: Fri, 6 Apr 2018 14:46:35 +0200 > From: Esben Haabendal <eha@deif.com> > > The current (mildly evil) fsl_pq_mdio code uses an undocumented shadow of > the TBIPA register on LS1021A, which happens to be read-only. > Changing TBI PHY address therefore does not work on LS1021A. > > The real (and documented) address of the TBIPA registere lies in the eTSEC > block and not in MDIO/MII, which is read/write, so using that fixes > the problem. > > Signed-off-by: Esben Haabendal <eha@deif.com> Applied. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-08 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180406123836.12019-2-esben.haabendal@gmail.com>
2018-04-06 12:46 ` [PATCH] ARM: dts: ls1021a: Specify TBIPA register address Esben Haabendal
2018-04-08 16:45 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).