From: Rob Herring <robh@kernel.org>
To: Stefan Popa <stefan.popa@analog.com>
Cc: sre@kernel.org, mark.rutland@arm.com, davem@davemloft.net,
mchehab@kernel.org, gregkh@linuxfoundation.org,
linus.walleij@linaro.org, akpm@linux-foundation.org,
rdunlap@infradead.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] adp5061: New driver for ADP5061 I2C battery charger
Date: Tue, 10 Apr 2018 08:50:17 -0500 [thread overview]
Message-ID: <20180410135017.7sikebbbdsdxjsxs@rob-hp-laptop> (raw)
In-Reply-To: <1522829832-7866-1-git-send-email-stefan.popa@analog.com>
On Wed, Apr 04, 2018 at 11:17:12AM +0300, Stefan Popa wrote:
> This patch adds basic support for Analog Devices I2C programmable linear
> battery charger.
>
> With this driver, some parameters can be read and configured such as:
> * trickle charge current level
> * trickle charge voltage threshold
> * weak charge threshold
> * constant current
> * constant charge voltage limit
> * battery full
> * input current limit
> * charger status
> * battery status
> * termination current
Don't you need to describe all these parameters of the battery used?
Charger bindings are never this simple.
>
> Datasheet:
> http://www.analog.com/media/en/technical-documentation/data-sheets/ADP5061.pdf
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> ---
> .../devicetree/bindings/power/supply/adp5061.txt | 17 +
Please split bindings to a separate patch.
> MAINTAINERS | 8 +
> drivers/power/supply/Kconfig | 11 +
> drivers/power/supply/Makefile | 1 +
> drivers/power/supply/adp5061.c | 745 +++++++++++++++++++++
> 5 files changed, 782 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/adp5061.txt
> create mode 100644 drivers/power/supply/adp5061.c
>
> diff --git a/Documentation/devicetree/bindings/power/supply/adp5061.txt b/Documentation/devicetree/bindings/power/supply/adp5061.txt
> new file mode 100644
> index 0000000..7447446
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/adp5061.txt
> @@ -0,0 +1,17 @@
> +Analog Devices ADP5061 Programmable Linear Battery Charger Driver
> +
> +Required properties:
> + - compatible: should be "adi,adp5061"
> + - reg: i2c address of the device
> +
> +The node for this driver must be a child node of a I2C controller, hence
> +all mandatory properties described in
> +Documentation/devicetree/bindings/i2c/i2c.txt
> +must be specified.
> +
> +Example:
> +
> + adp5061@14 {
> + compatible = "adi,adp5061";
> + reg = <0x14>;
> + };
next prev parent reply other threads:[~2018-04-10 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 8:17 [PATCH 1/3] adp5061: New driver for ADP5061 I2C battery charger Stefan Popa
2018-04-04 17:33 ` Randy Dunlap
2018-04-10 9:49 ` [PATCH v2 " Stefan Popa
2018-04-10 13:50 ` Rob Herring [this message]
2018-04-11 15:10 ` [PATCH v3 2/4] dt-bindings:power:supply: Add docs for ADP5061 " Stefan Popa
2018-04-13 21:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410135017.7sikebbbdsdxjsxs@rob-hp-laptop \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sre@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox