* [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver
[not found] <20180411015948.19562-1-andrew.smirnov@gmail.com>
@ 2018-04-11 1:59 ` Andrey Smirnov
2018-04-16 15:05 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Andrey Smirnov @ 2018-04-11 1:59 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Andrey Smirnov, linux-kernel, Chris Healy, Lucas Stach,
Aleksander Morgado, Rob Herring, Mark Rutland, devicetree
Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of
parent RAVE SP driver (documented in
Documentation/devicetree/bindings/mfd/zii,rave-sp.txt).
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Aleksander Morgado <aleksander@aleksander.es>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
.../bindings/nvmem/zii,rave-sp-eeprom.txt | 29 ++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
new file mode 100644
index 000000000000..a4e838c30b67
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
@@ -0,0 +1,29 @@
+Zodiac Inflight Innovations RAVE EEPROM Bindings
+
+RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM
+attached to RAVE Supervisory Processor. It is expected that its Device
+Tree node is specified as a child of the node corresponding to the
+parent RAVE SP device (as documented in
+Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
+
+Required properties:
+
+- compatible: Should be "zii,rave-sp-eeprom"
+
+Example:
+
+ rave-sp {
+ compatible = "zii,rave-sp-rdu1";
+ current-speed = <38400>;
+
+ main-eeprom {
+ compatible = "zii,rave-sp-eeprom";
+ reg = <0xA4 0x4000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ wdt_timeout: wdt-timeout@81 {
+ reg = <0x81 2>;
+ };
+ };
+ }
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver
2018-04-11 1:59 ` [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver Andrey Smirnov
@ 2018-04-16 15:05 ` Rob Herring
2018-04-27 6:05 ` Andrey Smirnov
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-04-16 15:05 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Srinivas Kandagatla, linux-kernel, Chris Healy, Lucas Stach,
Aleksander Morgado, Mark Rutland, devicetree
On Tue, Apr 10, 2018 at 06:59:47PM -0700, Andrey Smirnov wrote:
> Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of
> parent RAVE SP driver (documented in
> Documentation/devicetree/bindings/mfd/zii,rave-sp.txt).
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Aleksander Morgado <aleksander@aleksander.es>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> .../bindings/nvmem/zii,rave-sp-eeprom.txt | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>
> diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
> new file mode 100644
> index 000000000000..a4e838c30b67
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
> @@ -0,0 +1,29 @@
> +Zodiac Inflight Innovations RAVE EEPROM Bindings
> +
> +RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM
> +attached to RAVE Supervisory Processor. It is expected that its Device
> +Tree node is specified as a child of the node corresponding to the
> +parent RAVE SP device (as documented in
> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
> +
> +Required properties:
> +
> +- compatible: Should be "zii,rave-sp-eeprom"
Need to state somewhere this follows the bindings/nvmem/nvmem.txt
binding.
> +
> +Example:
> +
> + rave-sp {
> + compatible = "zii,rave-sp-rdu1";
> + current-speed = <38400>;
> +
> + main-eeprom {
eeprom@a4
> + compatible = "zii,rave-sp-eeprom";
> + reg = <0xA4 0x4000>;
lowercase hex please.
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + wdt_timeout: wdt-timeout@81 {
> + reg = <0x81 2>;
> + };
> + };
> + }
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver
2018-04-16 15:05 ` Rob Herring
@ 2018-04-27 6:05 ` Andrey Smirnov
2018-04-27 18:43 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Andrey Smirnov @ 2018-04-27 6:05 UTC (permalink / raw)
To: Rob Herring
Cc: Srinivas Kandagatla, linux-kernel, Chris Healy, Lucas Stach,
Aleksander Morgado, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Mon, Apr 16, 2018 at 8:05 AM, Rob Herring <robh@kernel.org> wrote:
> On Tue, Apr 10, 2018 at 06:59:47PM -0700, Andrey Smirnov wrote:
>> Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of
>> parent RAVE SP driver (documented in
>> Documentation/devicetree/bindings/mfd/zii,rave-sp.txt).
>>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Chris Healy <cphealy@gmail.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Aleksander Morgado <aleksander@aleksander.es>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: devicetree@vger.kernel.org
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>> ---
>> .../bindings/nvmem/zii,rave-sp-eeprom.txt | 29 ++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>> new file mode 100644
>> index 000000000000..a4e838c30b67
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>> @@ -0,0 +1,29 @@
>> +Zodiac Inflight Innovations RAVE EEPROM Bindings
>> +
>> +RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM
>> +attached to RAVE Supervisory Processor. It is expected that its Device
>> +Tree node is specified as a child of the node corresponding to the
>> +parent RAVE SP device (as documented in
>> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
>> +
>> +Required properties:
>> +
>> +- compatible: Should be "zii,rave-sp-eeprom"
>
> Need to state somewhere this follows the bindings/nvmem/nvmem.txt
> binding.
>
OK, will fix in v3.
>> +
>> +Example:
>> +
>> + rave-sp {
>> + compatible = "zii,rave-sp-rdu1";
>> + current-speed = <38400>;
>> +
>> + main-eeprom {
>
> eeprom@a4
Any chance I can keep it as is? I am asking because this node name is
used by the driver as device name which is how it also appears in
sysfs. Reason for that being that "main-eeprom" and "dds-eeprom"
(second EEPROM in the system) are easier to rembmer and tell apart
than "eeprom@a4" and "eeprom@a5". Granted, I can divorce naming scheme
in the driver from device node name, but then I'd have to keep a
"address -> deivce name" lookup table which I was hoping to avoid.
>
>> + compatible = "zii,rave-sp-eeprom";
>> + reg = <0xA4 0x4000>;
>
> lowercase hex please.
OK, will do in v3.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver
2018-04-27 6:05 ` Andrey Smirnov
@ 2018-04-27 18:43 ` Rob Herring
2018-04-27 19:38 ` Andrey Smirnov
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-04-27 18:43 UTC (permalink / raw)
To: Andrey Smirnov
Cc: Srinivas Kandagatla, linux-kernel, Chris Healy, Lucas Stach,
Aleksander Morgado, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Apr 27, 2018 at 1:05 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> On Mon, Apr 16, 2018 at 8:05 AM, Rob Herring <robh@kernel.org> wrote:
>> On Tue, Apr 10, 2018 at 06:59:47PM -0700, Andrey Smirnov wrote:
>>> Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of
>>> parent RAVE SP driver (documented in
>>> Documentation/devicetree/bindings/mfd/zii,rave-sp.txt).
>>>
>>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>> Cc: linux-kernel@vger.kernel.org
>>> Cc: Chris Healy <cphealy@gmail.com>
>>> Cc: Lucas Stach <l.stach@pengutronix.de>
>>> Cc: Aleksander Morgado <aleksander@aleksander.es>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Mark Rutland <mark.rutland@arm.com>
>>> Cc: devicetree@vger.kernel.org
>>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>>> ---
>>> .../bindings/nvmem/zii,rave-sp-eeprom.txt | 29 ++++++++++++++++++++++
>>> 1 file changed, 29 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>> new file mode 100644
>>> index 000000000000..a4e838c30b67
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>> @@ -0,0 +1,29 @@
>>> +Zodiac Inflight Innovations RAVE EEPROM Bindings
>>> +
>>> +RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM
>>> +attached to RAVE Supervisory Processor. It is expected that its Device
>>> +Tree node is specified as a child of the node corresponding to the
>>> +parent RAVE SP device (as documented in
>>> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
>>> +
>>> +Required properties:
>>> +
>>> +- compatible: Should be "zii,rave-sp-eeprom"
>>
>> Need to state somewhere this follows the bindings/nvmem/nvmem.txt
>> binding.
>>
>
> OK, will fix in v3.
>
>>> +
>>> +Example:
>>> +
>>> + rave-sp {
>>> + compatible = "zii,rave-sp-rdu1";
>>> + current-speed = <38400>;
>>> +
>>> + main-eeprom {
>>
>> eeprom@a4
>
> Any chance I can keep it as is? I am asking because this node name is
> used by the driver as device name which is how it also appears in
> sysfs. Reason for that being that "main-eeprom" and "dds-eeprom"
> (second EEPROM in the system) are easier to rembmer and tell apart
> than "eeprom@a4" and "eeprom@a5". Granted, I can divorce naming scheme
> in the driver from device node name, but then I'd have to keep a
> "address -> deivce name" lookup table which I was hoping to avoid.
It generates a dtc warning if you don't fix it.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver
2018-04-27 18:43 ` Rob Herring
@ 2018-04-27 19:38 ` Andrey Smirnov
0 siblings, 0 replies; 5+ messages in thread
From: Andrey Smirnov @ 2018-04-27 19:38 UTC (permalink / raw)
To: Rob Herring
Cc: Srinivas Kandagatla, linux-kernel, Chris Healy, Lucas Stach,
Aleksander Morgado, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Apr 27, 2018 at 11:43 AM, Rob Herring <robh@kernel.org> wrote:
> On Fri, Apr 27, 2018 at 1:05 AM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>> On Mon, Apr 16, 2018 at 8:05 AM, Rob Herring <robh@kernel.org> wrote:
>>> On Tue, Apr 10, 2018 at 06:59:47PM -0700, Andrey Smirnov wrote:
>>>> Add Device Tree bindings for RAVE SP EEPROM driver - an MFD cell of
>>>> parent RAVE SP driver (documented in
>>>> Documentation/devicetree/bindings/mfd/zii,rave-sp.txt).
>>>>
>>>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Cc: Chris Healy <cphealy@gmail.com>
>>>> Cc: Lucas Stach <l.stach@pengutronix.de>
>>>> Cc: Aleksander Morgado <aleksander@aleksander.es>
>>>> Cc: Rob Herring <robh+dt@kernel.org>
>>>> Cc: Mark Rutland <mark.rutland@arm.com>
>>>> Cc: devicetree@vger.kernel.org
>>>> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>>>> ---
>>>> .../bindings/nvmem/zii,rave-sp-eeprom.txt | 29 ++++++++++++++++++++++
>>>> 1 file changed, 29 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>>> new file mode 100644
>>>> index 000000000000..a4e838c30b67
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/nvmem/zii,rave-sp-eeprom.txt
>>>> @@ -0,0 +1,29 @@
>>>> +Zodiac Inflight Innovations RAVE EEPROM Bindings
>>>> +
>>>> +RAVE SP EEPROM device is a "MFD cell" device exposing physical EEPROM
>>>> +attached to RAVE Supervisory Processor. It is expected that its Device
>>>> +Tree node is specified as a child of the node corresponding to the
>>>> +parent RAVE SP device (as documented in
>>>> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
>>>> +
>>>> +Required properties:
>>>> +
>>>> +- compatible: Should be "zii,rave-sp-eeprom"
>>>
>>> Need to state somewhere this follows the bindings/nvmem/nvmem.txt
>>> binding.
>>>
>>
>> OK, will fix in v3.
>>
>>>> +
>>>> +Example:
>>>> +
>>>> + rave-sp {
>>>> + compatible = "zii,rave-sp-rdu1";
>>>> + current-speed = <38400>;
>>>> +
>>>> + main-eeprom {
>>>
>>> eeprom@a4
>>
>> Any chance I can keep it as is? I am asking because this node name is
>> used by the driver as device name which is how it also appears in
>> sysfs. Reason for that being that "main-eeprom" and "dds-eeprom"
>> (second EEPROM in the system) are easier to rembmer and tell apart
>> than "eeprom@a4" and "eeprom@a5". Granted, I can divorce naming scheme
>> in the driver from device node name, but then I'd have to keep a
>> "address -> deivce name" lookup table which I was hoping to avoid.
>
> It generates a dtc warning if you don't fix it.
>
Understood. Will fix in v3.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-27 19:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180411015948.19562-1-andrew.smirnov@gmail.com>
2018-04-11 1:59 ` [PATCH v2 1/2] dt-bindings: nvmem: Add binding for RAVE SP EEPROM driver Andrey Smirnov
2018-04-16 15:05 ` Rob Herring
2018-04-27 6:05 ` Andrey Smirnov
2018-04-27 18:43 ` Rob Herring
2018-04-27 19:38 ` Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).