Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995

[jacopo mondi <jacopo@jmondi.org>]

[-- Attachment #1: Type: text/plain, Size: 2183 bytes --]

Hello Kaneko-san,

On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote:
> This series adds thermal support for r8a77995.
> R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2.
> Therefore this series adds r8a77995 support to rcar_thermal driver not
> rcar_gen3_thermal driver.

I tested this on D3 Draak.

I generated load expecting the detected temperature to rise.

It took a while, and I only see a slight increase of the temperature
reported by the 'temp' attribute.

# cat /sys/class/thermal/thermal_zone0/temp
30000

# while :; do cat /dev/urandom > /dev/null; done
...(wait 2 minutes)

# cat /sys/class/thermal/thermal_zone0/temp
35000

(wait 30 seconds)

# cat /sys/class/thermal/thermal_zone0/temp
30000

Is this result ok for your testing?

Thanks
  j
>
> This series is based on the next branch of Zhang Rui's linux tree.
>
> v3 [Yoshihiro Kaneko]
> * As suggested by Geert Uytterhoeven
> rcar_thermal.c:
> - make use_of_thermal in structure rcar_thermal_chip a single bit
> - add feature bits to rcar_thermal_chip
> - add the number of interrupts to rcar_thermal_chip
> - remove rcar_thermal_type in rcar_thermal_cip
> - make variable chip in rcar_thermal_probe() a const
>
> rcar-thermal.txt:
> * No change
>
> r8a77995.dtsi:
> * No change
>
>
> v2 [Yoshihiro Kaneko]
> * As suggested by Geert Uytterhoeven
> rcar_thermal.c:
> - remove rcar_of_data macro
> - store a pointer to rcar_thermal_chip in rcar_thermal_priv
> - remove unnecessary cast in rcar_thermal_dt_ids
>
> rcar-thermal.txt:
> - drop the fallback for D3
> - update the paragraph about interrupts
>
> r8a77995.dtsi:
> - fix the base address and the register addresses
> - drop the fallback
>
> Yoshihiro Kaneko (3):
>   thermal: rcar_thermal: add r8a77995 support
>   dt-bindings: thermal: rcar-thermal: add R8A77995 support
>   arm64: dts: renesas: r8a77995: add thermal device support
>
>  .../devicetree/bindings/thermal/rcar-thermal.txt   |   7 +-
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi          |  30 ++++
>  drivers/thermal/rcar_thermal.c                     | 154 ++++++++++++++++-----
>  3 files changed, 157 insertions(+), 34 deletions(-)
>
> --
> 1.9.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]